* [PATCH 1/2] [media] VIDEO_MEDIATEK_VCODEC should depend on HAS_DMA
@ 2016-08-03 18:10 Geert Uytterhoeven
2016-08-03 18:10 ` [PATCH 2/2] [media] VIDEO_MEDIATEK_VPU " Geert Uytterhoeven
0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2016-08-03 18:10 UTC (permalink / raw)
To: Andrew-CT Chen, Tiffany Lin, Hans Verkuil, Mauro Carvalho Chehab
Cc: linux-media, linux-kernel, Geert Uytterhoeven
If NO_DMA=y:
warning: (VIDEO_MEDIATEK_VCODEC && VIDEO_DM365_VPFE && VIDEO_OMAP4) selects VIDEOBUF2_DMA_CONTIG which has unmet direct dependencies (MEDIA_SUPPORT && HAS_DMA)
drivers/media/v4l2-core/videobuf2-dma-contig.c: In function ‘vb2_dc_get_userptr’:
drivers/media/v4l2-core/videobuf2-dma-contig.c:486: error: implicit declaration of function ‘dma_get_cache_alignment’
VIDEO_MEDIATEK_VCODEC selects VIDEOBUF2_DMA_CONTIG, which bypasses its
dependency on HAS_DMA. Make VIDEO_MEDIATEK_VCODEC depend on HAS_DMA to
fix this.
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
drivers/media/platform/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig
index f25344bc79126e2f..552b635cfce7f02b 100644
--- a/drivers/media/platform/Kconfig
+++ b/drivers/media/platform/Kconfig
@@ -169,7 +169,7 @@ config VIDEO_MEDIATEK_VPU
config VIDEO_MEDIATEK_VCODEC
tristate "Mediatek Video Codec driver"
depends on MTK_IOMMU || COMPILE_TEST
- depends on VIDEO_DEV && VIDEO_V4L2
+ depends on VIDEO_DEV && VIDEO_V4L2 && HAS_DMA
depends on ARCH_MEDIATEK || COMPILE_TEST
select VIDEOBUF2_DMA_CONTIG
select V4L2_MEM2MEM_DEV
--
1.9.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH 2/2] [media] VIDEO_MEDIATEK_VPU should depend on HAS_DMA
2016-08-03 18:10 [PATCH 1/2] [media] VIDEO_MEDIATEK_VCODEC should depend on HAS_DMA Geert Uytterhoeven
@ 2016-08-03 18:10 ` Geert Uytterhoeven
0 siblings, 0 replies; 2+ messages in thread
From: Geert Uytterhoeven @ 2016-08-03 18:10 UTC (permalink / raw)
To: Andrew-CT Chen, Tiffany Lin, Hans Verkuil, Mauro Carvalho Chehab
Cc: linux-media, linux-kernel, Geert Uytterhoeven
If NO_DMA=y:
ERROR: "bad_dma_ops" [drivers/media/platform/mtk-vpu/mtk-vpu.ko] undefined!
Add a dependency on HAS_DMA to fix this.
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
drivers/media/platform/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig
index 552b635cfce7f02b..a6ed2e077ad0f2d2 100644
--- a/drivers/media/platform/Kconfig
+++ b/drivers/media/platform/Kconfig
@@ -155,7 +155,7 @@ config VIDEO_CODA
config VIDEO_MEDIATEK_VPU
tristate "Mediatek Video Processor Unit"
- depends on VIDEO_DEV && VIDEO_V4L2
+ depends on VIDEO_DEV && VIDEO_V4L2 && HAS_DMA
depends on ARCH_MEDIATEK || COMPILE_TEST
---help---
This driver provides downloading VPU firmware and
--
1.9.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-08-03 18:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-03 18:10 [PATCH 1/2] [media] VIDEO_MEDIATEK_VCODEC should depend on HAS_DMA Geert Uytterhoeven
2016-08-03 18:10 ` [PATCH 2/2] [media] VIDEO_MEDIATEK_VPU " Geert Uytterhoeven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®