* [PATCH] KEYS: fix big_key dependency
@ 2016-08-15 22:45 Kirill Marinushkin
2016-08-16 5:48 ` Stephan Mueller
0 siblings, 1 reply; 4+ messages in thread
From: Kirill Marinushkin @ 2016-08-15 22:45 UTC (permalink / raw)
To: dhowells
Cc: james.l.morris, serge, keyrings, linux-security-module,
linux-kernel, Kirill Marinushkin
Signed-off-by: Kirill Marinushkin <k.marinushkin@gmail.com>
---
security/keys/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/security/keys/Kconfig b/security/keys/Kconfig
index f826e87..8213221 100644
--- a/security/keys/Kconfig
+++ b/security/keys/Kconfig
@@ -44,7 +44,7 @@ config BIG_KEYS
select CRYPTO
select CRYPTO_AES
select CRYPTO_ECB
- select CRYPTO_RNG
+ select CRYPTO_ANSI_CPRNG
help
This option provides support for holding large keys within the kernel
(for example Kerberos ticket caches). The data may be stored out to
--
1.9.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] KEYS: fix big_key dependency
2016-08-15 22:45 [PATCH] KEYS: fix big_key dependency Kirill Marinushkin
@ 2016-08-16 5:48 ` Stephan Mueller
2016-08-16 19:51 ` [PATCH v2] " Kirill Marinushkin
2016-08-16 20:02 ` [PATCH] " Kirill Marinushkin
0 siblings, 2 replies; 4+ messages in thread
From: Stephan Mueller @ 2016-08-16 5:48 UTC (permalink / raw)
To: Kirill Marinushkin
Cc: dhowells, james.l.morris, serge, keyrings, linux-security-module,
linux-kernel
Am Dienstag, 16. August 2016, 00:45:39 CEST schrieb Kirill Marinushkin:
Hi Kirill,
> + select CRYPTO_ANSI_CPRNG
This change enables the RNG which will not pass FIPS testing any more. Hence,
this selection could cause an issue in FIPS mode (i.e. booting the kernel with
fips=1).
May I suggest CRYPTO_DRBG?
Ciao
Stephan
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2] KEYS: fix big_key dependency
2016-08-16 5:48 ` Stephan Mueller
@ 2016-08-16 19:51 ` Kirill Marinushkin
2016-08-16 20:02 ` [PATCH] " Kirill Marinushkin
1 sibling, 0 replies; 4+ messages in thread
From: Kirill Marinushkin @ 2016-08-16 19:51 UTC (permalink / raw)
To: dhowells
Cc: smueller, james.l.morris, serge, keyrings, linux-security-module,
linux-kernel, Kirill Marinushkin
This patch fixes the following bug:
[oss-security] - panic at big_key_preparse #4.7-r6/rc7 & master
Signed-off-by: Kirill Marinushkin <k.marinushkin@gmail.com>
---
security/keys/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/security/keys/Kconfig b/security/keys/Kconfig
index f826e87..5bc5114 100644
--- a/security/keys/Kconfig
+++ b/security/keys/Kconfig
@@ -44,7 +44,7 @@ config BIG_KEYS
select CRYPTO
select CRYPTO_AES
select CRYPTO_ECB
- select CRYPTO_RNG
+ select CRYPTO_RNG_DEFAULT
help
This option provides support for holding large keys within the kernel
(for example Kerberos ticket caches). The data may be stored out to
--
1.9.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] KEYS: fix big_key dependency
2016-08-16 5:48 ` Stephan Mueller
2016-08-16 19:51 ` [PATCH v2] " Kirill Marinushkin
@ 2016-08-16 20:02 ` Kirill Marinushkin
1 sibling, 0 replies; 4+ messages in thread
From: Kirill Marinushkin @ 2016-08-16 20:02 UTC (permalink / raw)
To: smueller
Cc: dhowells, james.l.morris, serge, keyrings, linux-security-module,
linux-kernel, Kirill Marinushkin
> May I suggest CRYPTO_DRBG?
Hello Ciao,
Thanks for your proposal. I submitted the PATCH v2 where I use
CRYPTO_RNG_DEFAULT the same way it is used in crypto/Kconfig.
It solves the issue, too. In addition, it selects CRYPTO_DRBG_MENU,
which is a more universal use-case, as I understood from your comment.
Best Regards,
Kirill
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-08-16 20:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-15 22:45 [PATCH] KEYS: fix big_key dependency Kirill Marinushkin
2016-08-16 5:48 ` Stephan Mueller
2016-08-16 19:51 ` [PATCH v2] " Kirill Marinushkin
2016-08-16 20:02 ` [PATCH] " Kirill Marinushkin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®