mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] CacheFiles: remove the check of fstop and bstop
@ 2016-08-22  7:47 Shawn Lin
  0 siblings, 0 replies; only message in thread
From: Shawn Lin @ 2016-08-22  7:47 UTC (permalink / raw)
  To: David Howells; +Cc: linux-cachefs, linux-kernel, Shawn Lin

No need to compare them with zero as it should
never be less than zero.

Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
---

 fs/cachefiles/daemon.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/cachefiles/daemon.c b/fs/cachefiles/daemon.c
index 1ee54ff..2ee88bd 100644
--- a/fs/cachefiles/daemon.c
+++ b/fs/cachefiles/daemon.c
@@ -386,7 +386,7 @@ static int cachefiles_daemon_fstop(struct cachefiles_cache *cache, char *args)
 	if (args[0] != '%' || args[1] != '\0')
 		return -EINVAL;
 
-	if (fstop < 0 || fstop >= cache->fcull_percent)
+	if (fstop >= cache->fcull_percent)
 		return cachefiles_daemon_range_error(cache, args);
 
 	cache->fstop_percent = fstop;
@@ -458,7 +458,7 @@ static int cachefiles_daemon_bstop(struct cachefiles_cache *cache, char *args)
 	if (args[0] != '%' || args[1] != '\0')
 		return -EINVAL;
 
-	if (bstop < 0 || bstop >= cache->bcull_percent)
+	if (bstop >= cache->bcull_percent)
 		return cachefiles_daemon_range_error(cache, args);
 
 	cache->bstop_percent = bstop;
-- 
2.3.7

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2016-08-22  7:51 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-22  7:47 [PATCH] CacheFiles: remove the check of fstop and bstop Shawn Lin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®