From: John Stultz <john.stultz@linaro.org>
To: lkml <linux-kernel@vger.kernel.org>
Cc: "Archit Taneja" <architt@codeaurora.org>,
"David Airlie" <airlied@linux.ie>,
"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
"Wolfram Sang" <wsa+renesas@sang-engineering.com>,
"Srinivas Kandagatla" <srinivas.kandagatla@linaro.org>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
"Boris Brezillon" <boris.brezillon@free-electrons.com>,
"Andy Green" <andy@warmcat.com>,
"Dave Long" <dave.long@linaro.org>,
"Guodong Xu" <guodong.xu@linaro.org>,
"Zhangfei Gao" <zhangfei.gao@linaro.org>,
"Mark Brown" <broonie@kernel.org>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Jose Abreu" <joabreu@synopsys.com>,
dri-devel@lists.freedesktop.org,
"John Stultz" <john.stultz@linaro.org>
Subject: [RFC][PATCH 1/4] drm/bridge: adv7511: Move the common data structures to header file
Date: Mon, 22 Aug 2016 22:50:44 -0700 [thread overview]
Message-ID: <1471931447-12049-2-git-send-email-john.stultz@linaro.org> (raw)
In-Reply-To: <1471931447-12049-1-git-send-email-john.stultz@linaro.org>
From: Archit Taneja <architt@codeaurora.org>
This patch moves the adv7511 data structure to header file so that the
audio driver file could use it.
Cc: David Airlie <airlied@linux.ie>
Cc: Archit Taneja <architt@codeaurora.org>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: Andy Green <andy@warmcat.com>
Cc: Dave Long <dave.long@linaro.org>
Cc: Guodong Xu <guodong.xu@linaro.org>
Cc: Zhangfei Gao <zhangfei.gao@linaro.org>
Cc: Mark Brown <broonie@kernel.org>
Cc: Lars-Peter Clausen <lars@metafoo.de>
Cc: Jose Abreu <joabreu@synopsys.com>
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Signed-off-by: John Stultz <john.stultz@linaro.org>
---
drivers/gpu/drm/bridge/adv7511/adv7511.h | 8 ++++++++
drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 4 ++--
2 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511.h b/drivers/gpu/drm/bridge/adv7511/adv7511.h
index 161c923..c7002a0 100644
--- a/drivers/gpu/drm/bridge/adv7511/adv7511.h
+++ b/drivers/gpu/drm/bridge/adv7511/adv7511.h
@@ -16,6 +16,14 @@
#include <drm/drm_crtc_helper.h>
#include <drm/drm_mipi_dsi.h>
+#include <drm/drm_crtc_helper.h>
+
+struct regmap;
+struct adv7511;
+
+int adv7511_packet_enable(struct adv7511 *adv7511, unsigned int packet);
+int adv7511_packet_disable(struct adv7511 *adv7511, unsigned int packet);
+
#define ADV7511_REG_CHIP_REVISION 0x00
#define ADV7511_REG_N0 0x01
#define ADV7511_REG_N1 0x02
diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
index ec8fb2e..f8eb7f8 100644
--- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
+++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
@@ -160,7 +160,7 @@ static void adv7511_set_colormap(struct adv7511 *adv7511, bool enable,
ADV7511_CSC_UPDATE_MODE, 0);
}
-static int adv7511_packet_enable(struct adv7511 *adv7511, unsigned int packet)
+int adv7511_packet_enable(struct adv7511 *adv7511, unsigned int packet)
{
if (packet & 0xff)
regmap_update_bits(adv7511->regmap, ADV7511_REG_PACKET_ENABLE0,
@@ -175,7 +175,7 @@ static int adv7511_packet_enable(struct adv7511 *adv7511, unsigned int packet)
return 0;
}
-static int adv7511_packet_disable(struct adv7511 *adv7511, unsigned int packet)
+int adv7511_packet_disable(struct adv7511 *adv7511, unsigned int packet)
{
if (packet & 0xff)
regmap_update_bits(adv7511->regmap, ADV7511_REG_PACKET_ENABLE0,
--
1.9.1
next prev parent reply other threads:[~2016-08-23 5:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-23 5:50 [RFC][PATCH 0/4] Audio support for adv7511 hdmi bridge John Stultz
2016-08-23 5:50 ` John Stultz [this message]
2016-08-23 5:50 ` [RFC][PATCH 2/4] drm/bridge: adv7511: Add Audio support John Stultz
2016-08-26 13:02 ` Srinivas Kandagatla
2016-08-23 5:50 ` [RFC][PATCH 3/4] drm/bridge: adv7511: Enable the audio data and clock pads on adv7533 John Stultz
2016-08-23 5:50 ` [RFC][PATCH 4/4] drm/bridge: adv7511: Initialize audio packet " John Stultz
2016-08-26 13:02 ` [RFC][PATCH 0/4] Audio support for adv7511 hdmi bridge Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1471931447-12049-2-git-send-email-john.stultz@linaro.org \
--to=john.stultz@linaro.org \
--cc=airlied@linux.ie \
--cc=andy@warmcat.com \
--cc=architt@codeaurora.org \
--cc=boris.brezillon@free-electrons.com \
--cc=broonie@kernel.org \
--cc=dave.long@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=guodong.xu@linaro.org \
--cc=joabreu@synopsys.com \
--cc=lars@metafoo.de \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=ville.syrjala@linux.intel.com \
--cc=wsa+renesas@sang-engineering.com \
--cc=zhangfei.gao@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®