mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alexander Shishkin <alexander.shishkin@linux.intel.com>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Ingo Molnar <mingo@redhat.com>,
	linux-kernel@vger.kernel.org, vince@deater.net,
	eranian@google.com, Arnaldo Carvalho de Melo <acme@infradead.org>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>
Subject: [PATCH 2/3] perf/x86/intel/bts: Kill a silly warning
Date: Tue, 23 Aug 2016 11:54:33 +0300	[thread overview]
Message-ID: <1471942474-1854-3-git-send-email-alexander.shishkin@linux.intel.com> (raw)
In-Reply-To: <1471942474-1854-1-git-send-email-alexander.shishkin@linux.intel.com>

At the moment, intel_bts will WARN() out if there is more than one
event writing to the same ring buffer, via SET_OUTPUT, and will only
send data from one event to a buffer.

There is no reason to have this warning in, so kill it.

Signed-off-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
---
 arch/x86/events/intel/bts.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/x86/events/intel/bts.c b/arch/x86/events/intel/bts.c
index 0b8ccff564..41975c6c2d 100644
--- a/arch/x86/events/intel/bts.c
+++ b/arch/x86/events/intel/bts.c
@@ -363,8 +363,6 @@ bts_buffer_reset(struct bts_buffer *buf, struct perf_output_handle *handle)
 		return 0;
 
 	head = handle->head & ((buf->nr_pages << PAGE_SHIFT) - 1);
-	if (WARN_ON_ONCE(head != local_read(&buf->head)))
-		return -EINVAL;
 
 	phys = &buf->buf[buf->cur_buf];
 	space = phys->offset + phys->displacement + phys->size - head;
-- 
2.8.1

  parent reply	other threads:[~2016-08-23  8:57 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-23  8:54 [PATCH 0/3] perf, bts: Fallout from the fuzzer for perf/urgent Alexander Shishkin
2016-08-23  8:54 ` [PATCH 1/3] perf/x86/intel/bts: Fix confused ordering of PMU callbacks Alexander Shishkin
2016-08-24 12:28   ` Alexander Shishkin
2016-08-24 14:15     ` Alexander Shishkin
2016-08-26 20:49       ` Vince Weaver
2016-08-27  6:35         ` Alexander Shishkin
2016-08-29 14:14       ` Peter Zijlstra
2016-08-29 14:43         ` Alexander Shishkin
2016-08-23  8:54 ` Alexander Shishkin [this message]
2016-08-23  8:54 ` [PATCH 3/3] perf: Fix a race between mmap_close and set_output of AUX events Alexander Shishkin
2016-08-23 16:24 ` [PATCH 0/3] perf, bts: Fallout from the fuzzer for perf/urgent Vince Weaver
2016-08-23 17:10   ` Alexander Shishkin
2016-08-23 20:55     ` Vince Weaver
2016-08-24  3:44       ` Alexander Shishkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1471942474-1854-3-git-send-email-alexander.shishkin@linux.intel.com \
    --to=alexander.shishkin@linux.intel.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@infradead.org \
    --cc=eranian@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=vince@deater.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®