From: Alexander Shishkin <alexander.shishkin@linux.intel.com>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org, vince@deater.net,
eranian@google.com, Arnaldo Carvalho de Melo <acme@infradead.org>
Subject: Re: [PATCH 1/3] perf/x86/intel/bts: Fix confused ordering of PMU callbacks
Date: Wed, 24 Aug 2016 15:28:22 +0300 [thread overview]
Message-ID: <87mvk2l5ax.fsf@ashishki-desk.ger.corp.intel.com> (raw)
In-Reply-To: <1471942474-1854-2-git-send-email-alexander.shishkin@linux.intel.com>
Alexander Shishkin <alexander.shishkin@linux.intel.com> writes:
> The intel_bts driver is using a cpu-local 'started' variable to order
> callbacks and PMIs and make sure that AUX transactions don't get messed
> up. However, the ordering rules in regard to this variable is a complete
> mess, which recently resulted in perf_fuzzer-triggered warnings and
> panics.
>
> The general ordering rule that is patch is enforcing is that this
> cpu-local variable be set only when the cpu-local AUX transaction is
> active; consequently, this variable is to be checked before the AUX
> related bits can be touched.
>
> Signed-off-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Ok, this one is broken, please disregard.
Regards,
--
Alex
next prev parent reply other threads:[~2016-08-24 12:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-23 8:54 [PATCH 0/3] perf, bts: Fallout from the fuzzer for perf/urgent Alexander Shishkin
2016-08-23 8:54 ` [PATCH 1/3] perf/x86/intel/bts: Fix confused ordering of PMU callbacks Alexander Shishkin
2016-08-24 12:28 ` Alexander Shishkin [this message]
2016-08-24 14:15 ` Alexander Shishkin
2016-08-26 20:49 ` Vince Weaver
2016-08-27 6:35 ` Alexander Shishkin
2016-08-29 14:14 ` Peter Zijlstra
2016-08-29 14:43 ` Alexander Shishkin
2016-08-23 8:54 ` [PATCH 2/3] perf/x86/intel/bts: Kill a silly warning Alexander Shishkin
2016-08-23 8:54 ` [PATCH 3/3] perf: Fix a race between mmap_close and set_output of AUX events Alexander Shishkin
2016-08-23 16:24 ` [PATCH 0/3] perf, bts: Fallout from the fuzzer for perf/urgent Vince Weaver
2016-08-23 17:10 ` Alexander Shishkin
2016-08-23 20:55 ` Vince Weaver
2016-08-24 3:44 ` Alexander Shishkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mvk2l5ax.fsf@ashishki-desk.ger.corp.intel.com \
--to=alexander.shishkin@linux.intel.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@infradead.org \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=vince@deater.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®