mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: John Garry <john.garry@huawei.com>
To: <jejb@linux.vnet.ibm.com>, <martin.petersen@oracle.com>
Cc: <linuxarm@huawei.com>, <zhangfei.gao@linaro.org>,
	<xuwei5@hisilicon.com>, <john.garry2@mail.dcu.ie>,
	<linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	John Garry <john.garry@huawei.com>
Subject: [PATCH v2 3/8] hisi_sas: add internal abort to hisi_sas_abort_task()
Date: Wed, 24 Aug 2016 19:05:49 +0800	[thread overview]
Message-ID: <1472036754-156813-4-git-send-email-john.garry@huawei.com> (raw)
In-Reply-To: <1472036754-156813-1-git-send-email-john.garry@huawei.com>

Execute an internal abort for executing a task abort.
This is for case of the command still being present
in host when abort is executed.

For a SATA internal abort, we set abort for all tasks
associated with the device.

Signed-off-by: John Garry <john.garry@huawei.com>
---
 drivers/scsi/hisi_sas/hisi_sas_main.c | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)

diff --git a/drivers/scsi/hisi_sas/hisi_sas_main.c b/drivers/scsi/hisi_sas/hisi_sas_main.c
index c4e59cd..280a19d 100644
--- a/drivers/scsi/hisi_sas/hisi_sas_main.c
+++ b/drivers/scsi/hisi_sas/hisi_sas_main.c
@@ -841,18 +841,22 @@ static int hisi_sas_abort_task(struct sas_task *task)
 			}
 		}
 
+		hisi_sas_internal_task_abort(hisi_hba, device,
+					     HISI_SAS_INT_ABT_CMD, tag);
 	} else if (task->task_proto & SAS_PROTOCOL_SATA ||
 		task->task_proto & SAS_PROTOCOL_STP) {
 		if (task->dev->dev_type == SAS_SATA_DEV) {
-			struct hisi_slot_info *slot = task->lldd_task;
-
-			dev_notice(dev, "abort task: hba=%p task=%p slot=%p\n",
-				   hisi_hba, task, slot);
-			task->task_state_flags |= SAS_TASK_STATE_ABORTED;
+			hisi_sas_internal_task_abort(hisi_hba, device,
+						     HISI_SAS_INT_ABT_DEV, 0);
 			rc = TMF_RESP_FUNC_COMPLETE;
-			goto out;
 		}
+	} else if (task->task_proto & SAS_PROTOCOL_SMP) {
+		/* SMP */
+		struct hisi_sas_slot *slot = task->lldd_task;
+		u32 tag = slot->idx;
 
+		hisi_sas_internal_task_abort(hisi_hba, device,
+					     HISI_SAS_INT_ABT_CMD, tag);
 	}
 
 out:
-- 
1.9.1

  parent reply	other threads:[~2016-08-24 10:49 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-24 11:05 [PATCH v2 0/8] hisi_sas internal abort support John Garry
2016-08-24 11:05 ` [PATCH v2 1/8] hisi_sas: add internal abort main code John Garry
2016-08-24 12:41   ` Hannes Reinecke
2016-08-24 11:05 ` [PATCH v2 2/8] hisi_sas: add internal abort in hisi_sas_dev_gone() John Garry
2016-08-24 12:41   ` Hannes Reinecke
2016-08-24 11:05 ` John Garry [this message]
2016-08-24 12:42   ` [PATCH v2 3/8] hisi_sas: add internal abort to hisi_sas_abort_task() Hannes Reinecke
2016-08-24 11:05 ` [PATCH v2 4/8] hisi_sas: add prep_abort_v2_hw() John Garry
2016-08-24 12:43   ` Hannes Reinecke
2016-08-24 11:05 ` [PATCH v2 5/8] hisi_sas: add v2 hw slot complete internal abort support John Garry
2016-08-24 12:59   ` Hannes Reinecke
2016-08-24 14:07     ` John Garry
2016-08-24 14:21       ` Hannes Reinecke
2016-08-24 11:05 ` [PATCH v2 6/8] hisi_sas: fail tmf task prep when port detached John Garry
2016-08-24 13:00   ` Hannes Reinecke
2016-08-24 11:05 ` [PATCH v2 7/8] hisi_sas: add TMF success check John Garry
2016-08-24 13:00   ` Hannes Reinecke
2016-08-24 11:05 ` [PATCH v2 8/8] hisi_sas: update version to 1.6 John Garry
2016-08-24 13:00   ` Hannes Reinecke
2016-08-26  2:40 ` [PATCH v2 0/8] hisi_sas internal abort support Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1472036754-156813-4-git-send-email-john.garry@huawei.com \
    --to=john.garry@huawei.com \
    --cc=jejb@linux.vnet.ibm.com \
    --cc=john.garry2@mail.dcu.ie \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    --cc=martin.petersen@oracle.com \
    --cc=xuwei5@hisilicon.com \
    --cc=zhangfei.gao@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®