From: Hannes Reinecke <hare@suse.de>
To: John Garry <john.garry@huawei.com>,
jejb@linux.vnet.ibm.com, martin.petersen@oracle.com
Cc: linuxarm@huawei.com, zhangfei.gao@linaro.org,
xuwei5@hisilicon.com, john.garry2@mail.dcu.ie,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 6/8] hisi_sas: fail tmf task prep when port detached
Date: Wed, 24 Aug 2016 15:00:12 +0200 [thread overview]
Message-ID: <9fe62988-55dd-d89f-10d0-eeb6aa2fea96@suse.de> (raw)
In-Reply-To: <1472036754-156813-7-git-send-email-john.garry@huawei.com>
On 08/24/2016 01:05 PM, John Garry wrote:
> When the port is detached we cannot execute a TMF,
> as there can be no device attached to the port.
>
> Signed-off-by: John Garry <john.garry@huawei.com>
> ---
> drivers/scsi/hisi_sas/hisi_sas_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/hisi_sas/hisi_sas_main.c b/drivers/scsi/hisi_sas/hisi_sas_main.c
> index 280a19d..73f581f 100644
> --- a/drivers/scsi/hisi_sas/hisi_sas_main.c
> +++ b/drivers/scsi/hisi_sas/hisi_sas_main.c
> @@ -204,7 +204,7 @@ static int hisi_sas_task_prep(struct sas_task *task, struct hisi_hba *hisi_hba,
> return rc;
> }
> port = device->port->lldd_port;
> - if (port && !port->port_attached && !tmf) {
> + if (port && !port->port_attached) {
> if (sas_protocol_ata(task->task_proto)) {
> struct task_status_struct *ts = &task->task_status;
>
>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
next prev parent reply other threads:[~2016-08-24 13:00 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-24 11:05 [PATCH v2 0/8] hisi_sas internal abort support John Garry
2016-08-24 11:05 ` [PATCH v2 1/8] hisi_sas: add internal abort main code John Garry
2016-08-24 12:41 ` Hannes Reinecke
2016-08-24 11:05 ` [PATCH v2 2/8] hisi_sas: add internal abort in hisi_sas_dev_gone() John Garry
2016-08-24 12:41 ` Hannes Reinecke
2016-08-24 11:05 ` [PATCH v2 3/8] hisi_sas: add internal abort to hisi_sas_abort_task() John Garry
2016-08-24 12:42 ` Hannes Reinecke
2016-08-24 11:05 ` [PATCH v2 4/8] hisi_sas: add prep_abort_v2_hw() John Garry
2016-08-24 12:43 ` Hannes Reinecke
2016-08-24 11:05 ` [PATCH v2 5/8] hisi_sas: add v2 hw slot complete internal abort support John Garry
2016-08-24 12:59 ` Hannes Reinecke
2016-08-24 14:07 ` John Garry
2016-08-24 14:21 ` Hannes Reinecke
2016-08-24 11:05 ` [PATCH v2 6/8] hisi_sas: fail tmf task prep when port detached John Garry
2016-08-24 13:00 ` Hannes Reinecke [this message]
2016-08-24 11:05 ` [PATCH v2 7/8] hisi_sas: add TMF success check John Garry
2016-08-24 13:00 ` Hannes Reinecke
2016-08-24 11:05 ` [PATCH v2 8/8] hisi_sas: update version to 1.6 John Garry
2016-08-24 13:00 ` Hannes Reinecke
2016-08-26 2:40 ` [PATCH v2 0/8] hisi_sas internal abort support Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9fe62988-55dd-d89f-10d0-eeb6aa2fea96@suse.de \
--to=hare@suse.de \
--cc=jejb@linux.vnet.ibm.com \
--cc=john.garry2@mail.dcu.ie \
--cc=john.garry@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=martin.petersen@oracle.com \
--cc=xuwei5@hisilicon.com \
--cc=zhangfei.gao@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®