mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Suzuki K Poulose <suzuki.poulose@arm.com>
To: will.deacon@arm.com, catalin.marinas@arm.com
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, marc.zyngier@arm.com,
	mark.rutland@arm.com, ard.biesheuvel@linaro.org,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	Andre Przywara <andre.przywara@arm.com>
Subject: [PATCH v2 6/9] arm64: alternative: Add support for patching adrp instructions
Date: Fri, 26 Aug 2016 10:23:15 +0100	[thread overview]
Message-ID: <1472203398-8751-7-git-send-email-suzuki.poulose@arm.com> (raw)
In-Reply-To: <1472203398-8751-1-git-send-email-suzuki.poulose@arm.com>

adrp uses PC-relative address offset to a page (of 4K size) of
a symbol. If it appears in an alternative code patched in, we
should adjust the offset to reflect the address where it will
be run from. This patch adds support for fixing the offset
for adrp instructions.

Cc: Will Deacon <will.deacon@arm.com>
Cc: Marc Zyngier <marc.zyngier@arm.com>
Cc: Andre Przywara <andre.przywara@arm.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>

---
Changes since V1:
 - Add align_down macro. Couldn't find the best place to add it.
   Didn't want to add this to uapi/ headers where the kernel's generic
   ALIGN helpers are really defined. For the time being left it here.
---
 arch/arm64/kernel/alternative.c | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/arch/arm64/kernel/alternative.c b/arch/arm64/kernel/alternative.c
index 6b269a9..d681498 100644
--- a/arch/arm64/kernel/alternative.c
+++ b/arch/arm64/kernel/alternative.c
@@ -59,6 +59,8 @@ static bool branch_insn_requires_update(struct alt_instr *alt, unsigned long pc)
 	BUG();
 }
 
+#define align_down(x, a)	((unsigned long)(x) & ~(((unsigned long)(a)) - 1))
+
 static u32 get_alt_insn(struct alt_instr *alt, u32 *insnptr, u32 *altinsnptr)
 {
 	u32 insn;
@@ -80,6 +82,19 @@ static u32 get_alt_insn(struct alt_instr *alt, u32 *insnptr, u32 *altinsnptr)
 			offset = target - (unsigned long)insnptr;
 			insn = aarch64_set_branch_offset(insn, offset);
 		}
+	} else if (aarch64_insn_is_adrp(insn)) {
+		s32 orig_offset, new_offset;
+		unsigned long target;
+
+		/*
+		 * If we're replacing an adrp instruction, which uses PC-relative
+		 * immediate addressing, adjust the offset to reflect the new
+		 * PC. adrp operates on 4K aligned addresses.
+		 */
+		orig_offset  = aarch64_insn_adrp_get_offset(insn);
+		target = align_down(altinsnptr, SZ_4K) + orig_offset;
+		new_offset = target - align_down(insnptr, SZ_4K);
+		insn = aarch64_insn_adrp_set_offset(insn, new_offset);
 	} else if (aarch64_insn_uses_literal(insn)) {
 		/*
 		 * Disallow patching unhandled instructions using PC relative
-- 
2.7.4

  parent reply	other threads:[~2016-08-26  9:25 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-26  9:23 [PATCH v2 0/9] arm64: Work around for mismatched cache line size Suzuki K Poulose
2016-08-26  9:23 ` [PATCH v2 1/9] arm64: Set the safe value for L1 icache policy Suzuki K Poulose
2016-08-26  9:23 ` [PATCH v2 2/9] arm64: Use consistent naming for errata handling Suzuki K Poulose
2016-08-26  9:23 ` [PATCH v2 3/9] arm64: Rearrange CPU errata workaround checks Suzuki K Poulose
2016-08-26  9:23 ` [PATCH v2 4/9] arm64: alternative: Disallow patching instructions using literals Suzuki K Poulose
2016-08-26  9:23 ` [PATCH v2 5/9] arm64: insn: Add helpers for adrp offsets Suzuki K Poulose
2016-08-26  9:23 ` Suzuki K Poulose [this message]
2016-08-26  9:23 ` [PATCH v2 7/9] arm64: Introduce raw_{d,i}cache_line_size Suzuki K Poulose
2016-08-26  9:23 ` [PATCH v2 8/9] arm64: Refactor sysinstr exception handling Suzuki K Poulose
2016-08-26  9:23 ` [PATCH v2 9/9] arm64: Work around systems with mismatched cache line sizes Suzuki K Poulose
2016-08-26 11:03   ` Ard Biesheuvel
2016-08-26 13:04     ` Suzuki K Poulose
2016-08-26 13:08       ` Suzuki K Poulose
2016-08-26 16:16         ` Will Deacon
2016-08-26 16:58           ` Ard Biesheuvel
2016-08-26 17:00           ` Catalin Marinas
2016-09-02 10:03             ` Suzuki K Poulose

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1472203398-8751-7-git-send-email-suzuki.poulose@arm.com \
    --to=suzuki.poulose@arm.com \
    --cc=andre.przywara@arm.com \
    --cc=ard.biesheuvel@linaro.org \
    --cc=catalin.marinas@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marc.zyngier@arm.com \
    --cc=mark.rutland@arm.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®