From: "Fenghua Yu" <fenghua.yu@intel.com>
To: "Thomas Gleixner" <tglx@linutronix.de>,
"H. Peter Anvin" <h.peter.anvin@intel.com>,
"Ingo Molnar" <mingo@elte.hu>, "Tony Luck" <tony.luck@intel.com>,
"Peter Zijlstra" <peterz@infradead.org>,
"Tejun Heo" <tj@kernel.org>, "Borislav Petkov" <bp@suse.de>,
"Stephane Eranian" <eranian@google.com>,
"Marcelo Tosatti" <mtosatti@redhat.com>,
"David Carrillo-Cisneros" <davidcc@google.com>,
"Shaohua Li" <shli@fb.com>,
"Ravi V Shankar" <ravi.v.shankar@intel.com>,
"Vikas Shivappa" <vikas.shivappa@linux.intel.com>,
"Sai Prakhya" <sai.praneeth.prakhya@intel.com>
Cc: "linux-kernel" <linux-kernel@vger.kernel.org>,
"x86" <x86@kernel.org>, Fenghua Yu <fenghua.yu@intel.com>
Subject: [PATCH v2 27/33] x86/intel_rdt_rdtgroup.c: Implement resctrl file system commands
Date: Thu, 8 Sep 2016 02:57:21 -0700 [thread overview]
Message-ID: <1473328647-33116-28-git-send-email-fenghua.yu@intel.com> (raw)
In-Reply-To: <1473328647-33116-1-git-send-email-fenghua.yu@intel.com>
From: Fenghua Yu <fenghua.yu@intel.com>
Four basic file system commands are implement for resctrl.
mount, umount, mkdir, and rmdir.
Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
Reviewed-by: Tony Luck <tony.luck@intel.com>
---
arch/x86/include/asm/intel_rdt_rdtgroup.h | 1 +
arch/x86/kernel/cpu/intel_rdt_rdtgroup.c | 211 ++++++++++++++++++++++++++++++
2 files changed, 212 insertions(+)
diff --git a/arch/x86/include/asm/intel_rdt_rdtgroup.h b/arch/x86/include/asm/intel_rdt_rdtgroup.h
index 92208a2..43a3b83 100644
--- a/arch/x86/include/asm/intel_rdt_rdtgroup.h
+++ b/arch/x86/include/asm/intel_rdt_rdtgroup.h
@@ -10,6 +10,7 @@
/* Defined in intel_rdt_rdtgroup.c.*/
extern int __init rdtgroup_init(void);
extern void rdtgroup_exit(struct task_struct *tsk);
+extern bool rdtgroup_mounted;
/* Defined in intel_rdt.c. */
extern struct list_head rdtgroup_lists;
diff --git a/arch/x86/kernel/cpu/intel_rdt_rdtgroup.c b/arch/x86/kernel/cpu/intel_rdt_rdtgroup.c
index acea62c..71231ba 100644
--- a/arch/x86/kernel/cpu/intel_rdt_rdtgroup.c
+++ b/arch/x86/kernel/cpu/intel_rdt_rdtgroup.c
@@ -51,6 +51,13 @@ static int rdt_info_show(struct seq_file *seq, void *v);
static int rdt_max_closid_show(struct seq_file *seq, void *v);
static int rdt_max_cbm_len_show(struct seq_file *seq, void *v);
static int domain_to_cache_id_show(struct seq_file *seq, void *v);
+static int rdtgroup_mkdir(struct kernfs_node *parent_kn, const char *name,
+ umode_t mode);
+static int rdtgroup_rmdir(struct kernfs_node *kn);
+static struct dentry *rdt_mount(struct file_system_type *fs_type,
+ int flags, const char *unused_dev_name,
+ void *data);
+static void rdt_kill_sb(struct super_block *sb);
/* rdtgroup core interface files */
static struct rftype rdtgroup_root_base_files[] = {
@@ -112,12 +119,24 @@ static struct rftype rdtgroup_partition_base_files[] = {
},
};
+static struct kernfs_syscall_ops rdtgroup_kf_syscall_ops = {
+ .mkdir = rdtgroup_mkdir,
+ .rmdir = rdtgroup_rmdir,
+};
+
+static struct file_system_type rdt_fs_type = {
+ .name = "resctrl",
+ .mount = rdt_mount,
+ .kill_sb = rdt_kill_sb,
+};
+
struct rdtgroup *root_rdtgrp;
static struct rftype rdtgroup_partition_base_files[];
struct cache_domain cache_domains[MAX_CACHE_LEAVES];
/* The default hierarchy. */
struct rdtgroup_root rdtgrp_dfl_root;
static struct list_head rdtgroups;
+bool rdtgroup_mounted;
/*
* kernfs_root - find out the kernfs_root a kernfs_node belongs to
@@ -730,6 +749,110 @@ static void rdtgroup_destroy_locked(struct rdtgroup *rdtgrp)
kernfs_remove(rdtgrp->kn);
}
+static int rdtgroup_mkdir(struct kernfs_node *parent_kn, const char *name,
+ umode_t mode)
+{
+ struct rdtgroup *parent, *rdtgrp;
+ struct rdtgroup_root *root;
+ struct kernfs_node *kn;
+ int ret;
+
+ if (parent_kn != root_rdtgrp->kn)
+ return -EPERM;
+
+ /* Do not accept '\n' to avoid unparsable situation.
+ */
+ if (strchr(name, '\n'))
+ return -EINVAL;
+
+ parent = rdtgroup_kn_lock_live(parent_kn);
+ if (!parent)
+ return -ENODEV;
+ root = parent->root;
+
+ /* allocate the rdtgroup. */
+ rdtgrp = kzalloc(sizeof(*rdtgrp), GFP_KERNEL);
+ if (!rdtgrp) {
+ ret = -ENOMEM;
+ goto out_unlock;
+ }
+
+ INIT_LIST_HEAD(&rdtgrp->pset.tasks);
+
+ cpumask_clear(&rdtgrp->cpu_mask);
+
+ rdtgrp->root = root;
+
+ /* create the directory */
+ kn = kernfs_create_dir(parent->kn, name, mode, rdtgrp);
+ if (IS_ERR(kn)) {
+ ret = PTR_ERR(kn);
+ goto out_cancel_ref;
+ }
+ rdtgrp->kn = kn;
+
+ /*
+ * This extra ref will be put in kernfs_remove() and guarantees
+ * that @rdtgrp->kn is always accessible.
+ */
+ kernfs_get(kn);
+
+ atomic_inc(&root->nr_rdtgrps);
+
+ ret = rdtgroup_kn_set_ugid(kn);
+ if (ret)
+ goto out_destroy;
+
+ ret = rdtgroup_partition_populate_dir(kn);
+ if (ret)
+ goto out_destroy;
+
+ kernfs_activate(kn);
+
+ list_add_tail(&rdtgrp->rdtgroup_list, &rdtgroup_lists);
+ /* Generate default schema for rdtgrp. */
+ ret = get_default_resources(rdtgrp);
+ if (ret)
+ goto out_destroy;
+
+ ret = 0;
+ goto out_unlock;
+
+out_cancel_ref:
+ kfree(rdtgrp);
+out_unlock:
+ rdtgroup_kn_unlock(parent_kn);
+ return ret;
+
+out_destroy:
+ rdtgroup_destroy_locked(rdtgrp);
+ goto out_unlock;
+}
+
+static int rdtgroup_rmdir(struct kernfs_node *kn)
+{
+ struct rdtgroup *rdtgrp;
+ int cpu;
+ int ret = 0;
+
+ rdtgrp = rdtgroup_kn_lock_live(kn);
+ if (!rdtgrp)
+ return -ENODEV;
+
+ if (!list_empty(&rdtgrp->pset.tasks)) {
+ ret = -EBUSY;
+ goto out;
+ }
+
+ for_each_cpu(cpu, &rdtgrp->cpu_mask)
+ per_cpu(cpu_rdtgroup, cpu) = root_rdtgrp;
+
+ rdtgroup_destroy_locked(rdtgrp);
+
+out:
+ rdtgroup_kn_unlock(kn);
+ return ret;
+}
static int
rdtgroup_move_task_all(struct rdtgroup *src_rdtgrp, struct rdtgroup *dst_rdtgrp)
{
@@ -978,3 +1101,91 @@ void rdtgroup_fork(struct task_struct *child)
out:
mutex_unlock(&rdtgroup_mutex);
}
+
+static struct dentry *rdt_mount(struct file_system_type *fs_type,
+ int flags, const char *unused_dev_name,
+ void *data)
+{
+ struct super_block *pinned_sb = NULL;
+ struct rdtgroup_root *root;
+ struct dentry *dentry;
+ int ret;
+ bool new_sb;
+
+ /*
+ * The first time anyone tries to mount a rdtgroup, enable the list
+ * linking tasks and fix up all existing tasks.
+ */
+ if (rdtgroup_mounted)
+ return ERR_PTR(-EBUSY);
+
+ rdt_opts.cdp_enabled = false;
+ rdt_opts.verbose = false;
+ cdp_enabled = false;
+
+ ret = parse_rdtgroupfs_options(data);
+ if (ret)
+ goto out_mount;
+
+ if (rdt_opts.cdp_enabled) {
+ cdp_enabled = true;
+ cconfig.max_closid >>= cdp_enabled;
+ pr_info("CDP is enabled\n");
+ }
+
+ init_msrs(cdp_enabled);
+
+ root = &rdtgrp_dfl_root;
+
+ ret = get_default_resources(&root->rdtgrp);
+ if (ret)
+ return ERR_PTR(-ENOSPC);
+
+out_mount:
+ dentry = kernfs_mount(fs_type, flags, root->kf_root,
+ RDTGROUP_SUPER_MAGIC,
+ &new_sb);
+ if (IS_ERR(dentry) || !new_sb)
+ goto out_unlock;
+
+ /*
+ * If @pinned_sb, we're reusing an existing root and holding an
+ * extra ref on its sb. Mount is complete. Put the extra ref.
+ */
+ if (pinned_sb) {
+ WARN_ON(new_sb);
+ deactivate_super(pinned_sb);
+ }
+
+ INIT_LIST_HEAD(&root->rdtgrp.pset.tasks);
+
+ cpumask_copy(&root->rdtgrp.cpu_mask, cpu_online_mask);
+ static_key_slow_inc(&rdt_enable_key);
+ rdtgroup_mounted = true;
+
+ return dentry;
+
+out_unlock:
+ return ERR_PTR(ret);
+}
+
+static void rdt_kill_sb(struct super_block *sb)
+{
+ mutex_lock(&rdtgroup_mutex);
+
+ rmdir_all_sub();
+
+ static_key_slow_dec(&rdt_enable_key);
+
+ release_root_closid();
+ root_rdtgrp->resource.valid = false;
+
+ /* Restore max_closid to original value. */
+ cconfig.max_closid <<= cdp_enabled;
+
+ kernfs_kill_sb(sb);
+ INIT_LIST_HEAD(&root_rdtgrp->pset.tasks);
+ rdtgroup_mounted = false;
+
+ mutex_unlock(&rdtgroup_mutex);
+}
--
2.5.0
next prev parent reply other threads:[~2016-09-08 7:00 UTC|newest]
Thread overview: 96+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-08 9:56 [PATCH v2 00/33] Enable Intel Resource Allocation in Resource Director Technology Fenghua Yu
2016-09-08 9:56 ` [PATCH v2 01/33] cacheinfo: Introduce cache id Fenghua Yu
2016-09-09 15:01 ` Nilay Vaish
2016-09-08 9:56 ` [PATCH v2 02/33] Documentation, ABI: Add a document entry for " Fenghua Yu
2016-09-08 19:33 ` Thomas Gleixner
2016-09-09 15:11 ` Nilay Vaish
2016-09-08 9:56 ` [PATCH v2 03/33] x86, intel_cacheinfo: Enable cache id in x86 Fenghua Yu
2016-09-08 9:56 ` [PATCH v2 04/33] drivers/base/cacheinfo.c: Export some cacheinfo functions for others to use Fenghua Yu
2016-09-08 8:21 ` Thomas Gleixner
2016-09-08 9:56 ` [PATCH v2 05/33] x86/intel_rdt: Cache Allocation documentation Fenghua Yu
2016-09-08 9:57 ` [PATCH v2 06/33] Documentation, x86: Documentation for Intel resource allocation user interface Fenghua Yu
2016-09-08 11:22 ` Borislav Petkov
2016-09-08 22:01 ` Shaohua Li
2016-09-09 1:17 ` Fenghua Yu
2016-09-08 22:45 ` Shaohua Li
2016-09-09 7:22 ` Fenghua Yu
2016-09-09 17:50 ` Shaohua Li
2016-09-09 18:03 ` Luck, Tony
2016-09-09 21:43 ` Shaohua Li
2016-09-09 21:59 ` Luck, Tony
2016-09-10 0:36 ` Yu, Fenghua
2016-09-12 4:15 ` Shaohua Li
2016-09-13 13:27 ` Thomas Gleixner
2016-09-08 9:57 ` [PATCH v2 07/33] x86/intel_rdt: Add support for Cache Allocation detection Fenghua Yu
2016-09-08 11:50 ` Borislav Petkov
2016-09-08 16:53 ` Yu, Fenghua
2016-09-08 17:17 ` Borislav Petkov
2016-09-08 13:17 ` Thomas Gleixner
2016-09-08 13:59 ` Yu, Fenghua
2016-09-13 22:40 ` Dave Hansen
2016-09-13 22:52 ` Luck, Tony
2016-09-13 23:00 ` Dave Hansen
2016-09-08 9:57 ` [PATCH v2 08/33] x86/intel_rdt: Add Class of service management Fenghua Yu
2016-09-08 8:56 ` Thomas Gleixner
2016-09-12 16:02 ` Nilay Vaish
2016-09-08 9:57 ` [PATCH v2 09/33] x86/intel_rdt: Add L3 cache capacity bitmask management Fenghua Yu
2016-09-08 9:40 ` Thomas Gleixner
2016-09-12 16:10 ` Nilay Vaish
2016-09-08 9:57 ` [PATCH v2 10/33] x86/intel_rdt: Implement scheduling support for Intel RDT Fenghua Yu
2016-09-08 9:53 ` Thomas Gleixner
2016-09-15 21:36 ` Yu, Fenghua
2016-09-15 21:40 ` Luck, Tony
2016-09-13 17:55 ` Nilay Vaish
2016-09-08 9:57 ` [PATCH v2 11/33] x86/intel_rdt: Hot cpu support for Cache Allocation Fenghua Yu
2016-09-08 10:03 ` Thomas Gleixner
2016-09-13 18:18 ` Nilay Vaish
2016-09-13 19:10 ` Luck, Tony
2016-09-08 9:57 ` [PATCH v2 12/33] x86/intel_rdt: Intel haswell Cache Allocation enumeration Fenghua Yu
2016-09-08 10:08 ` Thomas Gleixner
2016-09-08 9:57 ` [PATCH v2 13/33] Define CONFIG_INTEL_RDT Fenghua Yu
2016-09-08 10:14 ` Thomas Gleixner
2016-09-08 9:57 ` [PATCH v2 14/33] x86/intel_rdt: Intel Code Data Prioritization detection Fenghua Yu
2016-09-08 9:57 ` [PATCH v2 15/33] x86/intel_rdt: Adds support to enable Code Data Prioritization Fenghua Yu
2016-09-08 10:18 ` Thomas Gleixner
2016-09-08 9:57 ` [PATCH v2 16/33] x86/intel_rdt: Class of service and capacity bitmask management for CDP Fenghua Yu
2016-09-08 10:29 ` Thomas Gleixner
2016-09-08 9:57 ` [PATCH v2 17/33] x86/intel_rdt: Hot cpu update for code data prioritization Fenghua Yu
2016-09-08 10:34 ` Thomas Gleixner
2016-09-08 9:57 ` [PATCH v2 18/33] sched.h: Add rg_list and rdtgroup in task_struct Fenghua Yu
2016-09-08 10:36 ` Thomas Gleixner
2016-09-08 9:57 ` [PATCH v2 19/33] magic number for resctrl file system Fenghua Yu
2016-09-08 10:41 ` Thomas Gleixner
2016-09-08 10:47 ` Borislav Petkov
2016-09-08 9:57 ` [PATCH v2 20/33] x86/intel_rdt.h: Header for inter_rdt.c Fenghua Yu
2016-09-08 12:36 ` Thomas Gleixner
2016-09-08 9:57 ` [PATCH v2 21/33] x86/intel_rdt_rdtgroup.h: Header for user interface Fenghua Yu
2016-09-08 12:44 ` Thomas Gleixner
2016-09-08 9:57 ` [PATCH v2 22/33] x86/intel_rdt.c: Extend RDT to per cache and per resources Fenghua Yu
2016-09-08 14:57 ` Thomas Gleixner
2016-09-13 22:54 ` Dave Hansen
2016-09-08 9:57 ` [PATCH v2 23/33] x86/intel_rdt_rdtgroup.c: User interface for RDT Fenghua Yu
2016-09-08 14:59 ` Thomas Gleixner
2016-09-08 9:57 ` [PATCH v2 24/33] x86/intel_rdt_rdtgroup.c: Create info directory Fenghua Yu
2016-09-08 16:04 ` Thomas Gleixner
2016-09-08 9:57 ` [PATCH v2 25/33] include/linux/resctrl.h: Define fork and exit functions in a new header file Fenghua Yu
2016-09-08 16:07 ` Thomas Gleixner
2016-09-08 9:57 ` [PATCH v2 26/33] Task fork and exit for rdtgroup Fenghua Yu
2016-09-08 19:41 ` Thomas Gleixner
2016-09-13 23:13 ` Dave Hansen
2016-09-13 23:35 ` Luck, Tony
2016-09-14 14:28 ` Dave Hansen
2016-09-08 9:57 ` Fenghua Yu [this message]
2016-09-08 20:09 ` [PATCH v2 27/33] x86/intel_rdt_rdtgroup.c: Implement resctrl file system commands Thomas Gleixner
2016-09-08 22:04 ` Shaohua Li
2016-09-09 1:23 ` Fenghua Yu
2016-09-08 9:57 ` [PATCH v2 28/33] x86/intel_rdt_rdtgroup.c: Read and write cpus Fenghua Yu
2016-09-08 20:25 ` Thomas Gleixner
2016-09-08 9:57 ` [PATCH v2 29/33] x86/intel_rdt_rdtgroup.c: Tasks iterator and write Fenghua Yu
2016-09-08 20:50 ` Thomas Gleixner
2016-09-08 9:57 ` [PATCH v2 30/33] x86/intel_rdt_rdtgroup.c: Process schemata input from resctrl interface Fenghua Yu
2016-09-08 22:20 ` Thomas Gleixner
2016-09-08 9:57 ` [PATCH v2 31/33] Documentation/kernel-parameters: Add kernel parameter "resctrl" for CAT Fenghua Yu
2016-09-08 22:25 ` Thomas Gleixner
2016-09-08 9:57 ` [PATCH v2 32/33] MAINTAINERS: Add maintainer for Intel RDT resource allocation Fenghua Yu
2016-09-08 9:57 ` [PATCH v2 33/33] x86/Makefile: Build intel_rdt_rdtgroup.c Fenghua Yu
2016-09-08 23:59 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1473328647-33116-28-git-send-email-fenghua.yu@intel.com \
--to=fenghua.yu@intel.com \
--cc=bp@suse.de \
--cc=davidcc@google.com \
--cc=eranian@google.com \
--cc=h.peter.anvin@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mtosatti@redhat.com \
--cc=peterz@infradead.org \
--cc=ravi.v.shankar@intel.com \
--cc=sai.praneeth.prakhya@intel.com \
--cc=shli@fb.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=tony.luck@intel.com \
--cc=vikas.shivappa@linux.intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®