From: Jacek Anaszewski <j.anaszewski@samsung.com>
To: linux-leds@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, greg@kroah.com,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Jacek Anaszewski <j.anaszewski@samsung.com>
Subject: [PATCH] leds: triggers: Check return value of kobject_uevent_env()
Date: Mon, 19 Sep 2016 10:22:51 +0200 [thread overview]
Message-ID: <1474273371-6535-1-git-send-email-j.anaszewski@samsung.com> (raw)
From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Log error message if kobject_uevent_env() fails in led_trigger_set().
Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com>
---
drivers/leds/led-triggers.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/leds/led-triggers.c b/drivers/leds/led-triggers.c
index c7a38d4..f538e8c 100644
--- a/drivers/leds/led-triggers.c
+++ b/drivers/leds/led-triggers.c
@@ -141,7 +141,8 @@ void led_trigger_set(struct led_classdev *led_cdev, struct led_trigger *trig)
if (event) {
envp[0] = event;
envp[1] = NULL;
- kobject_uevent_env(&led_cdev->dev->kobj, KOBJ_CHANGE, envp);
+ if (kobject_uevent_env(&led_cdev->dev->kobj, KOBJ_CHANGE, envp))
+ pr_err("Error sending uevent after setting LED trigger\n");
kfree(event);
}
}
--
1.9.1
next reply other threads:[~2016-09-19 8:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-19 8:22 Jacek Anaszewski [this message]
2016-09-19 8:56 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1474273371-6535-1-git-send-email-j.anaszewski@samsung.com \
--to=j.anaszewski@samsung.com \
--cc=greg@kroah.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®