* [PATCH] mmc: dw_mmc: minor cleanup for dw_mci_adjust_fifoth @ 2016-09-21 2:40 ` Shawn Lin 2016-09-22 4:27 ` Jaehoon Chung 0 siblings, 1 reply; 2+ messages in thread From: Shawn Lin @ 2016-09-21 2:40 UTC (permalink / raw) To: Jaehoon Chung, Ulf Hansson Cc: linux-mmc, linux-kernel, linux-rockchip, Shawn Lin msize and rx_wmark are properly initialized, we dont't need to assign them again. Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com> --- drivers/mmc/host/dw_mmc.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c index 22dacae..d838428 100644 --- a/drivers/mmc/host/dw_mmc.c +++ b/drivers/mmc/host/dw_mmc.c @@ -876,11 +876,8 @@ static void dw_mci_adjust_fifoth(struct dw_mci *host, struct mmc_data *data) * MSIZE is '1', * if blksz is not a multiple of the FIFO width */ - if (blksz % fifo_width) { - msize = 0; - rx_wmark = 1; + if (blksz % fifo_width) goto done; - } do { if (!((blksz_depth % mszs[idx]) || -- 2.3.7 ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] mmc: dw_mmc: minor cleanup for dw_mci_adjust_fifoth 2016-09-21 2:40 ` [PATCH] mmc: dw_mmc: minor cleanup for dw_mci_adjust_fifoth Shawn Lin @ 2016-09-22 4:27 ` Jaehoon Chung 0 siblings, 0 replies; 2+ messages in thread From: Jaehoon Chung @ 2016-09-22 4:27 UTC (permalink / raw) To: Shawn Lin, Ulf Hansson; +Cc: linux-mmc, linux-kernel, linux-rockchip On 09/21/2016 11:40 AM, Shawn Lin wrote: > msize and rx_wmark are properly initialized, we dont't > need to assign them again. Applied on my tree. Thanks! Best Regards, Jaehoon Chung > > Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com> > --- > > drivers/mmc/host/dw_mmc.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c > index 22dacae..d838428 100644 > --- a/drivers/mmc/host/dw_mmc.c > +++ b/drivers/mmc/host/dw_mmc.c > @@ -876,11 +876,8 @@ static void dw_mci_adjust_fifoth(struct dw_mci *host, struct mmc_data *data) > * MSIZE is '1', > * if blksz is not a multiple of the FIFO width > */ > - if (blksz % fifo_width) { > - msize = 0; > - rx_wmark = 1; > + if (blksz % fifo_width) > goto done; > - } > > do { > if (!((blksz_depth % mszs[idx]) || > ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-09-22 4:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20160921024005epcas1p37f9a6a779906c283bb42e26f38c8d512@epcas1p3.samsung.com>
2016-09-21 2:40 ` [PATCH] mmc: dw_mmc: minor cleanup for dw_mci_adjust_fifoth Shawn Lin
2016-09-22 4:27 ` Jaehoon Chung
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®