From: Arvind Yadav <arvind.yadav.cs@gmail.com>
To: daniel.lezcano@linaro.org, tglx@linutronix.de,
vincent.guittot@linaro.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] clocksource: timer-imx-gpt: Unmap and free region obtained by of_iomap and kzalloc
Date: Thu, 22 Sep 2016 19:39:26 +0530 [thread overview]
Message-ID: <1474553366-8400-1-git-send-email-arvind.yadav.cs@gmail.com> (raw)
Free memory and memory mapping, if mxc_timer_init_dt is not successful.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/clocksource/timer-imx-gpt.c | 14 +++++++++++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/drivers/clocksource/timer-imx-gpt.c b/drivers/clocksource/timer-imx-gpt.c
index f595460..19f6860 100644
--- a/drivers/clocksource/timer-imx-gpt.c
+++ b/drivers/clocksource/timer-imx-gpt.c
@@ -489,12 +489,17 @@ static int __init mxc_timer_init_dt(struct device_node *np, enum imx_gpt_type t
return -ENOMEM;
imxtm->base = of_iomap(np, 0);
- if (!imxtm->base)
+ if (!imxtm->base) {
+ kfree(imxtm);
return -ENXIO;
+ }
imxtm->irq = irq_of_parse_and_map(np, 0);
- if (imxtm->irq <= 0)
+ if (imxtm->irq <= 0) {
+ iounmap(imxtm->base);
+ kfree(imxtm);
return -EINVAL;
+ }
imxtm->clk_ipg = of_clk_get_by_name(np, "ipg");
@@ -506,8 +511,11 @@ static int __init mxc_timer_init_dt(struct device_node *np, enum imx_gpt_type t
imxtm->type = type;
ret = _mxc_timer_init(imxtm);
- if (ret)
+ if (ret) {
+ iounmap(imxtm->base);
+ kfree(imxtm);
return ret;
+ }
initialized = 1;
--
2.7.4
next reply other threads:[~2016-09-22 14:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-22 14:09 Arvind Yadav [this message]
2016-09-22 14:16 ` Thomas Gleixner
2016-09-22 14:28 ` arvind Yadav
2016-09-22 14:36 ` Thomas Gleixner
2016-09-22 14:45 ` arvind Yadav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1474553366-8400-1-git-send-email-arvind.yadav.cs@gmail.com \
--to=arvind.yadav.cs@gmail.com \
--cc=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome