From: Babu Moger <babu.moger@oracle.com>
To: peterz@infradead.org, mingo@redhat.com,
akpm@linux-foundation.org, keescook@chromium.org,
dan.j.williams@intel.com, aryabinin@virtuozzo.com, tj@kernel.org
Cc: linux-kernel@vger.kernel.org, babu.moger@oracle.com
Subject: [PATCH 1/2] lockdep: Keep the default static allocations small
Date: Thu, 22 Sep 2016 11:43:35 -0700 [thread overview]
Message-ID: <1474569816-170269-2-git-send-email-babu.moger@oracle.com> (raw)
In-Reply-To: <1474569816-170269-1-git-send-email-babu.moger@oracle.com>
The Commit 1413c0389333 ("lockdep: Increase static allocations")
doubled the static allocation for lockdep. The size is unusually
high and not required for majority of the configurations. This
could cause problems to some environments with limited memory
configurations. We are already seeing issues on our sparc
configuration where kernel fails to boot when lockdep feature
is enabled. This patch keeps the default size to same as before
Commit 1413c0389333 ("lockdep: Increase static allocations").
Adding the new config parameter CONFIG_PROVE_LOCKING_PLUS in case
someone needs to enable more static space for lockdep entries,
lock chains and stack traces to debug large configurations.
Signed-off-by: Babu Moger <babu.moger@oracle.com>
---
kernel/locking/lockdep_internals.h | 14 +++++++++++---
1 files changed, 11 insertions(+), 3 deletions(-)
diff --git a/kernel/locking/lockdep_internals.h b/kernel/locking/lockdep_internals.h
index 51c4b24..47336a6 100644
--- a/kernel/locking/lockdep_internals.h
+++ b/kernel/locking/lockdep_internals.h
@@ -54,18 +54,26 @@ enum {
* table (if it's not there yet), and we check it for lock order
* conflicts and deadlocks.
*/
+#ifdef CONFIG_PROVE_LOCKING_PLUS
#define MAX_LOCKDEP_ENTRIES 32768UL
#define MAX_LOCKDEP_CHAINS_BITS 16
-#define MAX_LOCKDEP_CHAINS (1UL << MAX_LOCKDEP_CHAINS_BITS)
-
-#define MAX_LOCKDEP_CHAIN_HLOCKS (MAX_LOCKDEP_CHAINS*5)
/*
* Stack-trace: tightly packed array of stack backtrace
* addresses. Protected by the hash_lock.
*/
#define MAX_STACK_TRACE_ENTRIES 524288UL
+#else
+#define MAX_LOCKDEP_ENTRIES 16384UL
+#define MAX_LOCKDEP_CHAINS_BITS 15
+#define MAX_STACK_TRACE_ENTRIES 262144UL
+#endif
+
+#define MAX_LOCKDEP_CHAINS (1UL << MAX_LOCKDEP_CHAINS_BITS)
+
+#define MAX_LOCKDEP_CHAIN_HLOCKS (MAX_LOCKDEP_CHAINS*5)
+
extern struct list_head all_lock_classes;
extern struct lock_chain lock_chains[];
--
1.7.1
next prev parent reply other threads:[~2016-09-22 18:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-22 18:43 [PATCH 0/2] Ajust lockdep static allocations Babu Moger
2016-09-22 18:43 ` Babu Moger [this message]
2016-09-22 18:43 ` [PATCH 2/2] config: Add new CONFIG_PROVE_LOCKING_PLUS Babu Moger
2016-09-23 7:12 ` [PATCH 0/2] Ajust lockdep static allocations Peter Zijlstra
2016-09-23 14:04 ` Babu Moger
2016-09-23 14:34 ` Peter Zijlstra
2016-09-23 14:50 ` Babu Moger
2016-09-23 15:04 ` Peter Zijlstra
2016-09-23 15:15 ` Babu Moger
2016-09-23 15:40 ` Peter Zijlstra
2016-09-23 19:57 ` Babu Moger
2016-09-23 20:08 ` Rob Gardner
2016-09-23 20:17 ` Peter Zijlstra
2016-09-23 20:30 ` Babu Moger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1474569816-170269-2-git-send-email-babu.moger@oracle.com \
--to=babu.moger@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=aryabinin@virtuozzo.com \
--cc=dan.j.williams@intel.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®