From: Babu Moger <babu.moger@oracle.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: mingo@redhat.com, akpm@linux-foundation.org,
keescook@chromium.org, dan.j.williams@intel.com,
aryabinin@virtuozzo.com, tj@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] Ajust lockdep static allocations
Date: Fri, 23 Sep 2016 09:04:42 -0500 [thread overview]
Message-ID: <df54eb77-2aad-7801-9ddc-bc085f03d246@oracle.com> (raw)
In-Reply-To: <20160923071246.GJ2794@worktop>
On 9/23/2016 2:12 AM, Peter Zijlstra wrote:
> On Thu, Sep 22, 2016 at 11:43:34AM -0700, Babu Moger wrote:
>> These patches adjust the static allocations for lockdep
>> data structures used for debugging locking correctness. The current
>> code reserves about 4MB extra space for these data structures. Most
>> of the configurations do not need these many data structures. While
>> testing, I have not seen it go beyond 20% of already reserved entries.
>>
>> $grep "lock-classes" /proc/lockdep_stats
>> lock-classes: 1560 [max: 8191]
>>
>> Reserving even more space seems unreasonable. So, keeping the default
>> entries small as before the Commit 1413c0389333 ("lockdep: Increase static
>> allocations"). Added new CONFIG_PROVE_LOCKING_PLUS in case someone
>> needs more entries to debug their large configuration.
> Why make this more complicated? There's absolutely no upside to this
> change as far as I can see.
Peter, What do you mean? Revert the commit 1413c038933? Right now,
I cannot boot my setup after enabling lockdep. How do you think we can
handle this?
next prev parent reply other threads:[~2016-09-23 14:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-22 18:43 Babu Moger
2016-09-22 18:43 ` [PATCH 1/2] lockdep: Keep the default static allocations small Babu Moger
2016-09-22 18:43 ` [PATCH 2/2] config: Add new CONFIG_PROVE_LOCKING_PLUS Babu Moger
2016-09-23 7:12 ` [PATCH 0/2] Ajust lockdep static allocations Peter Zijlstra
2016-09-23 14:04 ` Babu Moger [this message]
2016-09-23 14:34 ` Peter Zijlstra
2016-09-23 14:50 ` Babu Moger
2016-09-23 15:04 ` Peter Zijlstra
2016-09-23 15:15 ` Babu Moger
2016-09-23 15:40 ` Peter Zijlstra
2016-09-23 19:57 ` Babu Moger
2016-09-23 20:08 ` Rob Gardner
2016-09-23 20:17 ` Peter Zijlstra
2016-09-23 20:30 ` Babu Moger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df54eb77-2aad-7801-9ddc-bc085f03d246@oracle.com \
--to=babu.moger@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=aryabinin@virtuozzo.com \
--cc=dan.j.williams@intel.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome