* [PATCH 1/2] EDAC, altera: Correct EDAC IRQ error message. @ 2016-09-22 22:13 tthayer 2016-09-22 22:13 ` [PATCH 2/2] EDAC, altera: Add IRQ Flags to disable IRQ while handling tthayer 2016-09-23 10:05 ` [PATCH 1/2] EDAC, altera: Correct EDAC IRQ error message Borislav Petkov 0 siblings, 2 replies; 3+ messages in thread From: tthayer @ 2016-09-22 22:13 UTC (permalink / raw) To: bp, mchehab; +Cc: linux-edac, linux-kernel, tthayer From: Thor Thayer <tthayer@opensource.altera.com> Correct the error message sent out in the case of a single bit error IRQ allocation. Signed-off-by: Thor Thayer <tthayer@opensource.altera.com> --- drivers/edac/altera_edac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/edac/altera_edac.c b/drivers/edac/altera_edac.c index 817e891..afe6305 100644 --- a/drivers/edac/altera_edac.c +++ b/drivers/edac/altera_edac.c @@ -1749,7 +1749,7 @@ static int altr_edac_a10_device_add(struct altr_arria10_edac *edac, prv->ecc_irq_handler, IRQF_SHARED, ecc_name, altdev); if (rc) { - edac_printk(KERN_ERR, EDAC_DEVICE, "No DBERR IRQ resource\n"); + edac_printk(KERN_ERR, EDAC_DEVICE, "No SBERR IRQ resource\n"); goto err_release_group1; } -- 1.7.9.5 ^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 2/2] EDAC, altera: Add IRQ Flags to disable IRQ while handling 2016-09-22 22:13 [PATCH 1/2] EDAC, altera: Correct EDAC IRQ error message tthayer @ 2016-09-22 22:13 ` tthayer 2016-09-23 10:05 ` [PATCH 1/2] EDAC, altera: Correct EDAC IRQ error message Borislav Petkov 1 sibling, 0 replies; 3+ messages in thread From: tthayer @ 2016-09-22 22:13 UTC (permalink / raw) To: bp, mchehab; +Cc: linux-edac, linux-kernel, tthayer From: Thor Thayer <tthayer@opensource.altera.com> Add the IRQF_ONESHOT and IRQF_TRIGGER_HIGH flags to disable the IRQ while executing the IRQ handler. Remove the IRQF_SHARED because these are not shared IRQs in the domain. Exposed when flooding IRQs. Signed-off-by: Thor Thayer <tthayer@opensource.altera.com> --- drivers/edac/altera_edac.c | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/drivers/edac/altera_edac.c b/drivers/edac/altera_edac.c index afe6305..58d3e2b 100644 --- a/drivers/edac/altera_edac.c +++ b/drivers/edac/altera_edac.c @@ -1445,7 +1445,8 @@ static int altr_portb_setup(struct altr_edac_device_dev *device) } rc = devm_request_irq(&altdev->ddev, altdev->sb_irq, prv->ecc_irq_handler, - IRQF_SHARED, ecc_name, altdev); + IRQF_ONESHOT | IRQF_TRIGGER_HIGH, + ecc_name, altdev); if (rc) { edac_printk(KERN_ERR, EDAC_DEVICE, "PortB SBERR IRQ error\n"); goto err_release_group_1; @@ -1459,7 +1460,8 @@ static int altr_portb_setup(struct altr_edac_device_dev *device) } rc = devm_request_irq(&altdev->ddev, altdev->db_irq, prv->ecc_irq_handler, - IRQF_SHARED, ecc_name, altdev); + IRQF_ONESHOT | IRQF_TRIGGER_HIGH, + ecc_name, altdev); if (rc) { edac_printk(KERN_ERR, EDAC_DEVICE, "PortB DBERR IRQ error\n"); goto err_release_group_1; @@ -1745,9 +1747,9 @@ static int altr_edac_a10_device_add(struct altr_arria10_edac *edac, rc = -ENODEV; goto err_release_group1; } - rc = devm_request_irq(edac->dev, altdev->sb_irq, - prv->ecc_irq_handler, - IRQF_SHARED, ecc_name, altdev); + rc = devm_request_irq(edac->dev, altdev->sb_irq, prv->ecc_irq_handler, + IRQF_ONESHOT | IRQF_TRIGGER_HIGH, + ecc_name, altdev); if (rc) { edac_printk(KERN_ERR, EDAC_DEVICE, "No SBERR IRQ resource\n"); goto err_release_group1; @@ -1759,9 +1761,9 @@ static int altr_edac_a10_device_add(struct altr_arria10_edac *edac, rc = -ENODEV; goto err_release_group1; } - rc = devm_request_irq(edac->dev, altdev->db_irq, - prv->ecc_irq_handler, - IRQF_SHARED, ecc_name, altdev); + rc = devm_request_irq(edac->dev, altdev->db_irq, prv->ecc_irq_handler, + IRQF_ONESHOT | IRQF_TRIGGER_HIGH, + ecc_name, altdev); if (rc) { edac_printk(KERN_ERR, EDAC_DEVICE, "No DBERR IRQ resource\n"); goto err_release_group1; -- 1.7.9.5 ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] EDAC, altera: Correct EDAC IRQ error message. 2016-09-22 22:13 [PATCH 1/2] EDAC, altera: Correct EDAC IRQ error message tthayer 2016-09-22 22:13 ` [PATCH 2/2] EDAC, altera: Add IRQ Flags to disable IRQ while handling tthayer @ 2016-09-23 10:05 ` Borislav Petkov 1 sibling, 0 replies; 3+ messages in thread From: Borislav Petkov @ 2016-09-23 10:05 UTC (permalink / raw) To: tthayer; +Cc: mchehab, linux-edac, linux-kernel On Thu, Sep 22, 2016 at 05:13:38PM -0500, tthayer@opensource.altera.com wrote: > From: Thor Thayer <tthayer@opensource.altera.com> > > Correct the error message sent out in the case of a single > bit error IRQ allocation. > > Signed-off-by: Thor Thayer <tthayer@opensource.altera.com> > --- > drivers/edac/altera_edac.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Both applied, thanks. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-09-23 10:05 UTC | newest] Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2016-09-22 22:13 [PATCH 1/2] EDAC, altera: Correct EDAC IRQ error message tthayer 2016-09-22 22:13 ` [PATCH 2/2] EDAC, altera: Add IRQ Flags to disable IRQ while handling tthayer 2016-09-23 10:05 ` [PATCH 1/2] EDAC, altera: Correct EDAC IRQ error message Borislav Petkov
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®