From: Bastien Nocera <hadess@hadess.net>
To: Nikita Yushchenko <nikita.yoush@cogentembedded.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>, Jyri Sarha <jsarha@ti.com>,
Peter Ujfalusi <peter.ujfalusi@ti.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Cc: Chris Healy <cphealy@gmail.com>
Subject: Re: [PATCH] ASoC: tlv320aic31xx: add explicit support for tlv320dac31xx
Date: Fri, 23 Sep 2016 11:03:14 +0200 [thread overview]
Message-ID: <1474621394.10437.19.camel@hadess.net> (raw)
In-Reply-To: <1474574803-4007-1-git-send-email-nikita.yoush@cogentembedded.com>
On Thu, 2016-09-22 at 23:06 +0300, Nikita Yushchenko wrote:
> tlv320dac31xx is a subset of tlv320aic31xx:
> - it does not have MIC inputs and ADC, thus capture is not supported,
> - it has analog inputs AIN1/AIN2 that can be mixed into output.
>
> Although tlv320dac31xx does work with tlv320aic31xx driver, this
> setup
> does register non-existent widgets and non-existent capture stream.
> Thus userspace lists non-existent objects in user interfaces, an can
> access these, causing operations with device registers that are
> declared as "reserved" in tlv320dac31xx datasheet.
>
> This patch fixes this situation by separating controls/widgets/routes
> into common, aic31xx-specific, and dac31xx-specific parts. Only parts
> that match actual hardware (as declared in "compatible" device tree
> property) are registered.
>
> Signed-off-by: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
I don't have access to the hardware. My original patch allowed playback
to work (ish) on a specific device that I don't own. Probably best to
ignore my patch, or even revert it before applying this one.
Cheers
next prev parent reply other threads:[~2016-09-23 9:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-22 20:06 Nikita Yushchenko
2016-09-23 8:25 ` Peter Ujfalusi
2016-09-23 11:52 ` [PATCH v2] " Nikita Yushchenko
2016-09-26 16:43 ` Applied "ASoC: tlv320aic31xx: add explicit support for tlv320dac31xx" to the asoc tree Mark Brown
2016-09-23 9:03 ` Bastien Nocera [this message]
2016-10-25 19:24 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1474621394.10437.19.camel@hadess.net \
--to=hadess@hadess.net \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=cphealy@gmail.com \
--cc=jsarha@ti.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nikita.yoush@cogentembedded.com \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@ti.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®