From: Sergio Paracuellos <sergio.paracuellos@gmail.com>
To: gregkh@linuxfoundation.org
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: [PATCH 11/20] staging: wlan-ng: avoid new typedef: p80211itemd_t
Date: Fri, 23 Sep 2016 15:45:28 +0200 [thread overview]
Message-ID: <1474638337-15399-13-git-send-email-sergio.paracuellos@gmail.com> (raw)
In-Reply-To: <1474638337-15399-1-git-send-email-sergio.paracuellos@gmail.com>
This patch fixes the following checkpatch.pl warning in p80211types.h:
WARNING: do not add new typedefs
It applies for typedef p80211itemd_t
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
---
drivers/staging/wlan-ng/p80211req.c | 3 ++-
drivers/staging/wlan-ng/p80211types.h | 4 ++--
drivers/staging/wlan-ng/prism2fw.c | 4 ++--
drivers/staging/wlan-ng/prism2mib.c | 4 ++--
4 files changed, 8 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/wlan-ng/p80211req.c b/drivers/staging/wlan-ng/p80211req.c
index 7b655b5a..5ddf5ba 100644
--- a/drivers/staging/wlan-ng/p80211req.c
+++ b/drivers/staging/wlan-ng/p80211req.c
@@ -195,7 +195,8 @@ static void p80211req_mibset_mibget(struct wlandevice *wlandev,
struct p80211msg_dot11req_mibget *mib_msg,
int isget)
{
- p80211itemd_t *mibitem = (p80211itemd_t *) mib_msg->mibattribute.data;
+ struct p80211itemd *mibitem = (struct p80211itemd *)
+ mib_msg->mibattribute.data;
struct p80211pstrd *pstr = (struct p80211pstrd *)mibitem->data;
u8 *key = mibitem->data + sizeof(struct p80211pstrd);
diff --git a/drivers/staging/wlan-ng/p80211types.h b/drivers/staging/wlan-ng/p80211types.h
index 6540044..57a65a8 100644
--- a/drivers/staging/wlan-ng/p80211types.h
+++ b/drivers/staging/wlan-ng/p80211types.h
@@ -262,12 +262,12 @@ struct p80211item {
} __packed;
/* prototype template w/ data item */
-typedef struct p80211itemd {
+struct p80211itemd {
u32 did;
u16 status;
u16 len;
u8 data[0];
-} __packed p80211itemd_t;
+} __packed;
/* message data item for int, BOUNDEDINT, ENUMINT */
typedef struct p80211item_uint32 {
diff --git a/drivers/staging/wlan-ng/prism2fw.c b/drivers/staging/wlan-ng/prism2fw.c
index 161637b..667fdf8 100644
--- a/drivers/staging/wlan-ng/prism2fw.c
+++ b/drivers/staging/wlan-ng/prism2fw.c
@@ -243,7 +243,7 @@ static int prism2_fwapply(const struct ihex_binrec *rfptr,
{
signed int result = 0;
struct p80211msg_dot11req_mibget getmsg;
- p80211itemd_t *item;
+ struct p80211itemd *item;
u32 *data;
/* Initialize the data structures */
@@ -293,7 +293,7 @@ static int prism2_fwapply(const struct ihex_binrec *rfptr,
getmsg.resultcode.did = DIDmsg_dot11req_mibget_resultcode;
getmsg.resultcode.status = P80211ENUM_msgitem_status_no_value;
- item = (p80211itemd_t *) getmsg.mibattribute.data;
+ item = (struct p80211itemd *)getmsg.mibattribute.data;
item->did = DIDmib_p2_p2NIC_p2PRISupRange;
item->status = P80211ENUM_msgitem_status_no_value;
diff --git a/drivers/staging/wlan-ng/prism2mib.c b/drivers/staging/wlan-ng/prism2mib.c
index 5f21c66..5d6e080 100644
--- a/drivers/staging/wlan-ng/prism2mib.c
+++ b/drivers/staging/wlan-ng/prism2mib.c
@@ -266,7 +266,7 @@ int prism2mgmt_mibset_mibget(struct wlandevice *wlandev, void *msgp)
u16 which;
struct p80211msg_dot11req_mibset *msg = msgp;
- p80211itemd_t *mibitem;
+ struct p80211itemd *mibitem;
msg->resultcode.status = P80211ENUM_msgitem_status_data_ok;
msg->resultcode.data = P80211ENUM_resultcode_success;
@@ -284,7 +284,7 @@ int prism2mgmt_mibset_mibget(struct wlandevice *wlandev, void *msgp)
** MIB table.
*/
- mibitem = (p80211itemd_t *) msg->mibattribute.data;
+ mibitem = (struct p80211itemd *)msg->mibattribute.data;
for (mib = mibtab; mib->did != 0; mib++)
if (mib->did == mibitem->did && (mib->flag & which))
--
1.9.1
next prev parent reply other threads:[~2016-09-23 13:47 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-23 13:45 [PATCH 00/20] staging: wlan-ng: fix some style issues in p80211types.h Sergio Paracuellos
2016-09-23 13:45 ` [PATCH 01/20] staging: wlan-ng: avoid new typedef: p80211enumpair_t Sergio Paracuellos
2016-09-23 13:45 ` [PATCH] staging: wlan-ng: avoid to introduce new typedefs Sergio Paracuellos
2016-09-23 16:59 ` Greg KH
2016-09-23 18:03 ` Sergio Paracuellos
2016-09-23 13:45 ` [PATCH 02/20] staging: wlan-ng: avoid new typedef: p80211enum_t Sergio Paracuellos
2016-09-23 13:45 ` [PATCH 03/20] staging: wlan-ng: avoid new typedef: p80211pstr_t Sergio Paracuellos
2016-09-23 13:45 ` [PATCH 04/20] staging: wlan-ng: avoid new typedef: p80211pstrd_t Sergio Paracuellos
2016-09-25 10:39 ` Greg KH
2016-09-25 13:34 ` [PATCH v2 00/17] staging: wlan-ng: fix some style issues in p80211types.h Sergio Paracuellos
2016-09-25 13:34 ` [PATCH v2 01/17] staging: wlan-ng: avoid new typedef: p80211pstrd_t Sergio Paracuellos
2016-09-25 13:34 ` [PATCH v2 02/17] staging: wlan-ng: avoid new typedef: p80211pstr255_t Sergio Paracuellos
2016-09-25 13:34 ` [PATCH v2 03/17] staging: wlan-ng: avoid new typedef: p80211pstr6_t Sergio Paracuellos
2016-09-25 13:34 ` [PATCH v2 04/17] staging: wlan-ng: avoid new typedef: p80211pstr14_t Sergio Paracuellos
2016-09-25 13:34 ` [PATCH v2 05/17] staging: wlan-ng: avoid new typedef: p80211pstr32_t Sergio Paracuellos
2016-09-25 13:34 ` [PATCH v2 06/17] staging: wlan-ng: avoid new typedef: p80211macarray_t Sergio Paracuellos
2016-09-25 13:34 ` [PATCH v2 07/17] staging: wlan-ng: avoid new typedef: p80211item_t Sergio Paracuellos
2016-09-25 13:34 ` [PATCH v2 08/17] staging: wlan-ng: avoid new typedef: p80211itemd_t Sergio Paracuellos
2016-09-25 13:35 ` [PATCH v2 09/17] staging: wlan-ng: avoid new typedef: p80211item_uint32_t Sergio Paracuellos
2016-09-25 13:35 ` [PATCH v2 10/17] staging: wlan-ng: avoid new typedef: p80211item_pstr6_t Sergio Paracuellos
2016-09-25 13:35 ` [PATCH v2 11/17] staging: wlan-ng: avoid new typedef: p80211item_pstr14_t Sergio Paracuellos
2016-09-25 13:35 ` [PATCH v2 12/17] staging: wlan-ng: avoid new typedef: p80211item_pstr32_t Sergio Paracuellos
2016-09-25 13:35 ` [PATCH v2 13/17] staging: wlan-ng: avoid new typedef: p80211item_pstr255_t Sergio Paracuellos
2016-09-25 13:35 ` [PATCH v2 14/17] staging: wlan-ng: avoid new typedef: p80211item_unk392_t Sergio Paracuellos
2016-09-25 13:35 ` [PATCH v2 15/17] staging: wlan-ng: avoid new typedef: p80211item_unk1024_t Sergio Paracuellos
2016-09-25 13:35 ` [PATCH v2 16/17] staging: wlan-ng: avoid new typedef: p80211item_unk4096_t Sergio Paracuellos
2016-09-25 13:35 ` [PATCH v2 17/17] staging: wlan-ng: fix block comments style errors Sergio Paracuellos
2016-09-25 13:51 ` Christoph Carlsen
2016-09-23 13:45 ` [PATCH 05/20] staging: wlan-ng: avoid new typedef: p80211pstr255_t Sergio Paracuellos
2016-09-23 13:45 ` [PATCH 06/20] staging: wlan-ng: avoid new typedef: p80211pstr6_t Sergio Paracuellos
2016-09-23 13:45 ` [PATCH 07/20] staging: wlan-ng: avoid new typedef: p80211pstr14_t Sergio Paracuellos
2016-09-23 13:45 ` [PATCH 08/20] staging: wlan-ng: avoid new typedef: p80211pstr32_t Sergio Paracuellos
2016-09-23 13:45 ` [PATCH 09/20] staging: wlan-ng: avoid new typedef: p80211macarray_t Sergio Paracuellos
2016-09-23 13:45 ` [PATCH 10/20] staging: wlan-ng: avoid new typedef: p80211item_t Sergio Paracuellos
2016-09-23 13:45 ` Sergio Paracuellos [this message]
2016-09-23 13:45 ` [PATCH 12/20] staging: wlan-ng: avoid new typedef: p80211item_uint32_t Sergio Paracuellos
2016-09-23 13:45 ` [PATCH 13/20] staging: wlan-ng: avoid new typedef: p80211item_pstr6_t Sergio Paracuellos
2016-09-23 13:45 ` [PATCH 14/20] staging: wlan-ng: avoid new typedef: p80211item_pstr14_t Sergio Paracuellos
2016-09-23 13:45 ` [PATCH 15/20] staging: wlan-ng: avoid new typedef: p80211item_pstr32_t Sergio Paracuellos
2016-09-23 13:45 ` [PATCH 16/20] staging: wlan-ng: avoid new typedef: p80211item_pstr255_t Sergio Paracuellos
2016-09-23 13:45 ` [PATCH 17/20] staging: wlan-ng: avoid new typedef: p80211item_unk392_t Sergio Paracuellos
2016-09-23 13:45 ` [PATCH 18/20] staging: wlan-ng: avoid new typedef: p80211item_unk1024_t Sergio Paracuellos
2016-09-23 13:45 ` [PATCH 19/20] staging: wlan-ng: avoid new typedef: p80211item_unk4096_t Sergio Paracuellos
2016-09-23 13:45 ` [PATCH 20/20] staging: wlan-ng: fix block comments style errors Sergio Paracuellos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1474638337-15399-13-git-send-email-sergio.paracuellos@gmail.com \
--to=sergio.paracuellos@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome