From: Sergio Paracuellos <sergio.paracuellos@gmail.com>
To: gregkh@linuxfoundation.org
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: [PATCH 15/20] staging: wlan-ng: avoid new typedef: p80211item_pstr32_t
Date: Fri, 23 Sep 2016 15:45:32 +0200 [thread overview]
Message-ID: <1474638337-15399-17-git-send-email-sergio.paracuellos@gmail.com> (raw)
In-Reply-To: <1474638337-15399-1-git-send-email-sergio.paracuellos@gmail.com>
This patch fixes the following checkpatch.pl warning in p80211types.h:
WARNING: do not add new typedefs
It applies for typedef p80211item_pstr32_t
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
---
drivers/staging/wlan-ng/cfg80211.c | 4 ++--
drivers/staging/wlan-ng/p80211metastruct.h | 8 ++++----
drivers/staging/wlan-ng/p80211types.h | 4 ++--
3 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/wlan-ng/cfg80211.c b/drivers/staging/wlan-ng/cfg80211.c
index 9f05c17..182b2d5 100644
--- a/drivers/staging/wlan-ng/cfg80211.c
+++ b/drivers/staging/wlan-ng/cfg80211.c
@@ -86,8 +86,8 @@ static int prism2_domibset_pstr32(struct wlandevice *wlandev,
u32 did, u8 len, const u8 *data)
{
struct p80211msg_dot11req_mibset msg;
- p80211item_pstr32_t *mibitem =
- (p80211item_pstr32_t *)&msg.mibattribute.data;
+ struct p80211item_pstr32 *mibitem =
+ (struct p80211item_pstr32 *)&msg.mibattribute.data;
msg.msgcode = DIDmsg_dot11req_mibset;
mibitem->did = did;
diff --git a/drivers/staging/wlan-ng/p80211metastruct.h b/drivers/staging/wlan-ng/p80211metastruct.h
index c9d4bb5..c66fc5a 100644
--- a/drivers/staging/wlan-ng/p80211metastruct.h
+++ b/drivers/staging/wlan-ng/p80211metastruct.h
@@ -70,7 +70,7 @@ struct p80211msg_dot11req_scan {
struct p80211item_uint32 bsstype;
struct p80211item_pstr6 bssid;
u8 pad_0C[1];
- p80211item_pstr32_t ssid;
+ struct p80211item_pstr32 ssid;
u8 pad_1D[3];
struct p80211item_uint32 scantype;
struct p80211item_uint32 probedelay;
@@ -93,7 +93,7 @@ struct p80211msg_dot11req_scan_results {
struct p80211item_uint32 noise;
struct p80211item_pstr6 bssid;
u8 pad_3C[1];
- p80211item_pstr32_t ssid;
+ struct p80211item_pstr32 ssid;
u8 pad_4D[3];
struct p80211item_uint32 bsstype;
struct p80211item_uint32 beaconperiod;
@@ -136,7 +136,7 @@ struct p80211msg_dot11req_start {
u32 msgcode;
u32 msglen;
u8 devname[WLAN_DEVNAMELEN_MAX];
- p80211item_pstr32_t ssid;
+ struct p80211item_pstr32 ssid;
u8 pad_12D[3];
struct p80211item_uint32 bsstype;
struct p80211item_uint32 beaconperiod;
@@ -217,7 +217,7 @@ struct p80211msg_lnxreq_autojoin {
u32 msgcode;
u32 msglen;
u8 devname[WLAN_DEVNAMELEN_MAX];
- p80211item_pstr32_t ssid;
+ struct p80211item_pstr32 ssid;
u8 pad_19D[3];
struct p80211item_uint32 authtype;
struct p80211item_uint32 resultcode;
diff --git a/drivers/staging/wlan-ng/p80211types.h b/drivers/staging/wlan-ng/p80211types.h
index 4d70d84..6c87729 100644
--- a/drivers/staging/wlan-ng/p80211types.h
+++ b/drivers/staging/wlan-ng/p80211types.h
@@ -294,12 +294,12 @@ struct p80211item_pstr14 {
} __packed;
/* message data item for OCTETSTR, DISPLAYSTR */
-typedef struct p80211item_pstr32 {
+struct p80211item_pstr32 {
u32 did;
u16 status;
u16 len;
struct p80211pstr32 data;
-} __packed p80211item_pstr32_t;
+} __packed;
/* message data item for OCTETSTR, DISPLAYSTR */
typedef struct p80211item_pstr255 {
--
1.9.1
next prev parent reply other threads:[~2016-09-23 13:48 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-23 13:45 [PATCH 00/20] staging: wlan-ng: fix some style issues in p80211types.h Sergio Paracuellos
2016-09-23 13:45 ` [PATCH 01/20] staging: wlan-ng: avoid new typedef: p80211enumpair_t Sergio Paracuellos
2016-09-23 13:45 ` [PATCH] staging: wlan-ng: avoid to introduce new typedefs Sergio Paracuellos
2016-09-23 16:59 ` Greg KH
2016-09-23 18:03 ` Sergio Paracuellos
2016-09-23 13:45 ` [PATCH 02/20] staging: wlan-ng: avoid new typedef: p80211enum_t Sergio Paracuellos
2016-09-23 13:45 ` [PATCH 03/20] staging: wlan-ng: avoid new typedef: p80211pstr_t Sergio Paracuellos
2016-09-23 13:45 ` [PATCH 04/20] staging: wlan-ng: avoid new typedef: p80211pstrd_t Sergio Paracuellos
2016-09-25 10:39 ` Greg KH
2016-09-25 13:34 ` [PATCH v2 00/17] staging: wlan-ng: fix some style issues in p80211types.h Sergio Paracuellos
2016-09-25 13:34 ` [PATCH v2 01/17] staging: wlan-ng: avoid new typedef: p80211pstrd_t Sergio Paracuellos
2016-09-25 13:34 ` [PATCH v2 02/17] staging: wlan-ng: avoid new typedef: p80211pstr255_t Sergio Paracuellos
2016-09-25 13:34 ` [PATCH v2 03/17] staging: wlan-ng: avoid new typedef: p80211pstr6_t Sergio Paracuellos
2016-09-25 13:34 ` [PATCH v2 04/17] staging: wlan-ng: avoid new typedef: p80211pstr14_t Sergio Paracuellos
2016-09-25 13:34 ` [PATCH v2 05/17] staging: wlan-ng: avoid new typedef: p80211pstr32_t Sergio Paracuellos
2016-09-25 13:34 ` [PATCH v2 06/17] staging: wlan-ng: avoid new typedef: p80211macarray_t Sergio Paracuellos
2016-09-25 13:34 ` [PATCH v2 07/17] staging: wlan-ng: avoid new typedef: p80211item_t Sergio Paracuellos
2016-09-25 13:34 ` [PATCH v2 08/17] staging: wlan-ng: avoid new typedef: p80211itemd_t Sergio Paracuellos
2016-09-25 13:35 ` [PATCH v2 09/17] staging: wlan-ng: avoid new typedef: p80211item_uint32_t Sergio Paracuellos
2016-09-25 13:35 ` [PATCH v2 10/17] staging: wlan-ng: avoid new typedef: p80211item_pstr6_t Sergio Paracuellos
2016-09-25 13:35 ` [PATCH v2 11/17] staging: wlan-ng: avoid new typedef: p80211item_pstr14_t Sergio Paracuellos
2016-09-25 13:35 ` [PATCH v2 12/17] staging: wlan-ng: avoid new typedef: p80211item_pstr32_t Sergio Paracuellos
2016-09-25 13:35 ` [PATCH v2 13/17] staging: wlan-ng: avoid new typedef: p80211item_pstr255_t Sergio Paracuellos
2016-09-25 13:35 ` [PATCH v2 14/17] staging: wlan-ng: avoid new typedef: p80211item_unk392_t Sergio Paracuellos
2016-09-25 13:35 ` [PATCH v2 15/17] staging: wlan-ng: avoid new typedef: p80211item_unk1024_t Sergio Paracuellos
2016-09-25 13:35 ` [PATCH v2 16/17] staging: wlan-ng: avoid new typedef: p80211item_unk4096_t Sergio Paracuellos
2016-09-25 13:35 ` [PATCH v2 17/17] staging: wlan-ng: fix block comments style errors Sergio Paracuellos
2016-09-25 13:51 ` Christoph Carlsen
2016-09-23 13:45 ` [PATCH 05/20] staging: wlan-ng: avoid new typedef: p80211pstr255_t Sergio Paracuellos
2016-09-23 13:45 ` [PATCH 06/20] staging: wlan-ng: avoid new typedef: p80211pstr6_t Sergio Paracuellos
2016-09-23 13:45 ` [PATCH 07/20] staging: wlan-ng: avoid new typedef: p80211pstr14_t Sergio Paracuellos
2016-09-23 13:45 ` [PATCH 08/20] staging: wlan-ng: avoid new typedef: p80211pstr32_t Sergio Paracuellos
2016-09-23 13:45 ` [PATCH 09/20] staging: wlan-ng: avoid new typedef: p80211macarray_t Sergio Paracuellos
2016-09-23 13:45 ` [PATCH 10/20] staging: wlan-ng: avoid new typedef: p80211item_t Sergio Paracuellos
2016-09-23 13:45 ` [PATCH 11/20] staging: wlan-ng: avoid new typedef: p80211itemd_t Sergio Paracuellos
2016-09-23 13:45 ` [PATCH 12/20] staging: wlan-ng: avoid new typedef: p80211item_uint32_t Sergio Paracuellos
2016-09-23 13:45 ` [PATCH 13/20] staging: wlan-ng: avoid new typedef: p80211item_pstr6_t Sergio Paracuellos
2016-09-23 13:45 ` [PATCH 14/20] staging: wlan-ng: avoid new typedef: p80211item_pstr14_t Sergio Paracuellos
2016-09-23 13:45 ` Sergio Paracuellos [this message]
2016-09-23 13:45 ` [PATCH 16/20] staging: wlan-ng: avoid new typedef: p80211item_pstr255_t Sergio Paracuellos
2016-09-23 13:45 ` [PATCH 17/20] staging: wlan-ng: avoid new typedef: p80211item_unk392_t Sergio Paracuellos
2016-09-23 13:45 ` [PATCH 18/20] staging: wlan-ng: avoid new typedef: p80211item_unk1024_t Sergio Paracuellos
2016-09-23 13:45 ` [PATCH 19/20] staging: wlan-ng: avoid new typedef: p80211item_unk4096_t Sergio Paracuellos
2016-09-23 13:45 ` [PATCH 20/20] staging: wlan-ng: fix block comments style errors Sergio Paracuellos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1474638337-15399-17-git-send-email-sergio.paracuellos@gmail.com \
--to=sergio.paracuellos@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome