mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Wookje Kwon <aweee0@gmail.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
	Taeung Song <taeung@kosslab.kr>, Wookje Kwon <aweee0@gmail.com>
Subject: [PATCH] perf config: Fix a bug about permission checking state of config file
Date: Fri, 30 Sep 2016 05:20:56 +0900	[thread overview]
Message-ID: <1475180456-5624-1-git-send-email-aweee0@gmail.com> (raw)

perf_config_set__init() check state of user config file
before opening it. But there is a bug when checking uid
and euid of current user. Although current user have superuser
permission, a error occurs as below.

Before:

user01@localhost:~$ ls -l ~/.perfconfig
-rw-rw-r-- 1 user01 user01 89 2016-09-30 01:52 /home/user01/.perfconfig

user01@localhost:~/linux-perf/tools/perf/util$ sudo perf config --list
  Warning: File /home/user01/.perfconfig not owned by current user or root, ignoring it.
  Warning: File /home/user01/.perfconfig not owned by current user or root, ignoring it.

So, Fix it allowing a user who have superuser permission
to open user config file.

After:

user01@localhost:~$ ls -l ~/.perfconfig
-rw-rw-r-- 1 user01 user01 89  2016-09-30 01:52 /home/user01/.perfconfig

user01@localhost:~$ sudo perf config --list
annotate.hide_src_code=false
report.queue-size=0
tui.report=on
colors.top=red, default

Cc: Taeung Song <taeung@kosslab.kr>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>
Signed-off-by: Wookje Kwon <aweee0@gmail.com>
---
 tools/perf/util/config.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tools/perf/util/config.c b/tools/perf/util/config.c
index 18dae74..f390ef9db 100644
--- a/tools/perf/util/config.c
+++ b/tools/perf/util/config.c
@@ -619,6 +619,7 @@ static int perf_config_set__init(struct perf_config_set *set)
 	if (perf_config_global() && home) {
 		char *user_config = strdup(mkpath("%s/.perfconfig", home));
 		struct stat st;
+		unsigned int st_euid = geteuid();
 
 		if (user_config == NULL) {
 			warning("Not enough memory to process %s/.perfconfig, "
@@ -629,7 +630,7 @@ static int perf_config_set__init(struct perf_config_set *set)
 		if (stat(user_config, &st) < 0)
 			goto out_free;
 
-		if (st.st_uid && (st.st_uid != geteuid())) {
+		if (st.st_uid && st_euid && (st.st_uid != st_euid)) {
 			warning("File %s not owned by current user or root, "
 				"ignoring it.", user_config);
 			goto out_free;
-- 
2.1.0

                 reply	other threads:[~2016-09-29 20:21 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1475180456-5624-1-git-send-email-aweee0@gmail.com \
    --to=aweee0@gmail.com \
    --cc=acme@kernel.org \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=taeung@kosslab.kr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®