* [PATCH] pwm: tiehrpwm: fix disabled state of pwm when inverted
@ 2016-10-03 11:37 Clifton Barnes
0 siblings, 0 replies; only message in thread
From: Clifton Barnes @ 2016-10-03 11:37 UTC (permalink / raw)
To: thierry.reding; +Cc: linux-pwm, linux-kernel
The disable function forces the output to low regardless of whether
the PWM is inverted. Fix this by checking the inverted status of the
PWM and force the output to the proper state when disabled.
Signed-off-by: Clifton Barnes <cabarnes@indesign-llc.com>
---
drivers/pwm/pwm-tiehrpwm.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/pwm/pwm-tiehrpwm.c b/drivers/pwm/pwm-tiehrpwm.c
index b5c6b06..e47e020 100644
--- a/drivers/pwm/pwm-tiehrpwm.c
+++ b/drivers/pwm/pwm-tiehrpwm.c
@@ -372,13 +372,14 @@ static void ehrpwm_pwm_disable(struct pwm_chip *chip, struct pwm_device *pwm)
{
struct ehrpwm_pwm_chip *pc = to_ehrpwm_pwm_chip(chip);
unsigned short aqcsfrc_val, aqcsfrc_mask;
+ bool inv = pc->polarity[pwm->hwpwm] == PWM_POLARITY_INVERSED;
- /* Action Qualifier puts PWM output low forcefully */
+ /* Action Qualifier puts PWM output high/low forcefully */
if (pwm->hwpwm) {
- aqcsfrc_val = AQCSFRC_CSFB_FRCLOW;
+ aqcsfrc_val = inv ? AQCSFRC_CSFB_FRCHIGH : AQCSFRC_CSFB_FRCLOW;
aqcsfrc_mask = AQCSFRC_CSFB_MASK;
} else {
- aqcsfrc_val = AQCSFRC_CSFA_FRCLOW;
+ aqcsfrc_val = inv ? AQCSFRC_CSFA_FRCHIGH : AQCSFRC_CSFA_FRCLOW;
aqcsfrc_mask = AQCSFRC_CSFA_MASK;
}
--
1.7.9.5
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2016-10-03 11:52 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-03 11:37 [PATCH] pwm: tiehrpwm: fix disabled state of pwm when inverted Clifton Barnes
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®