mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andy Grover <agrover@redhat.com>
To: gregkh@linuxfoundation.org, snitzer@redhat.com
Cc: dm-devel@redhat.com, linux-kernel@vger.kernel.org
Subject: [PATCH 0/9] Generate uevents for all DM events
Date: Mon,  3 Oct 2016 12:22:51 -0700	[thread overview]
Message-ID: <1475522580-16723-1-git-send-email-agrover@redhat.com> (raw)

Hi Mike and GregKH,

I want a way to get devicemapper events without using the DM ioctl,
because that requires creating a thread to sleep in the ioctl for each
dm device I want events from.

It would seem like using uevents and KOBJ_CHANGE would be a good way
to do this, but Mike said that the uevent maintainers (Greg that's
you?) did not think this was a good idea?

If so, I was hoping you could talk a little more about why -- grep
shows KOBJ_CHANGE used all over, but its usage is not documented in
kobject.txt. In any case I can update kobject.txt with some more
guidelines.

The following patchset may be appliable if you're actually ok with
using KOBJ_CHANGE for dm events, or if not, then I'll look to rework
it to use a dm-specific genetlink approach.

Thanks -- Regards -- Andy

Andy Grover (9):
  dm: Do not export dm_send_uevents
  dm: Move multipath-specific stuff out of dm-uevent.c
  dm: Inline dm_build_path_uevent into dm_path_uevent
  dm: Update dm-uevent.txt
  dm: Rename dm_build_uevent to dm_uevent_build
  dm: Rename dm_event_add to dm_event_queue
  dm: Implement dm_uevent_add()
  dm: Generate uevents for thin targets
  dm: Generate uevents for other targets

 Documentation/device-mapper/dm-uevent.txt |  54 ++++++++++++++--
 drivers/md/dm-cache-target.c              |   5 +-
 drivers/md/dm-log-userspace-base.c        |   8 ++-
 drivers/md/dm-log.c                       |   1 +
 drivers/md/dm-mpath.c                     |  56 ++++++++++++++++
 drivers/md/dm-raid1.c                     |   1 +
 drivers/md/dm-snap.c                      |   1 +
 drivers/md/dm-thin.c                      |   3 +
 drivers/md/dm-uevent.c                    | 102 ++++++++++--------------------
 drivers/md/dm-uevent.h                    |  30 +++++++--
 drivers/md/dm.c                           |   3 +-
 include/linux/device-mapper.h             |   3 +-
 12 files changed, 180 insertions(+), 87 deletions(-)

-- 
2.7.4

             reply	other threads:[~2016-10-03 19:23 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-03 19:22 Andy Grover [this message]
2016-10-03 19:22 ` [PATCH 1/9] dm: Do not export dm_send_uevents Andy Grover
2016-10-03 19:22 ` [PATCH 2/9] dm: Move multipath-specific stuff out of dm-uevent.c Andy Grover
2016-10-03 19:22 ` [PATCH 3/9] dm: Inline dm_build_path_uevent into dm_path_uevent Andy Grover
2016-10-03 19:22 ` [PATCH 4/9] dm: Update dm-uevent.txt Andy Grover
2016-10-03 19:22 ` [PATCH 5/9] dm: Rename dm_build_uevent to dm_uevent_build Andy Grover
2016-10-03 19:22 ` [PATCH 6/9] dm: Rename dm_event_add to dm_event_queue Andy Grover
2016-10-03 19:22 ` [PATCH 7/9] dm: Implement dm_uevent_add() Andy Grover
2016-10-03 19:22 ` [PATCH 8/9] dm: Generate uevents for thin targets Andy Grover
2016-10-03 19:23 ` [PATCH 9/9] dm: Generate uevents for other targets Andy Grover
2016-10-03 19:29 ` [PATCH 0/9] Generate uevents for all DM events Mike Snitzer
2016-10-04  7:20 ` Greg KH
2016-10-04 23:39   ` Andy Grover
2016-10-05  0:40     ` [dm-devel] " Alasdair G Kergon
2016-10-05  6:26       ` Hannes Reinecke
2016-10-05  6:51       ` Greg KH
2016-10-05 17:06         ` Andy Grover
2016-10-05 17:43           ` Alasdair G Kergon
2016-10-05 22:30             ` Andy Grover

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1475522580-16723-1-git-send-email-agrover@redhat.com \
    --to=agrover@redhat.com \
    --cc=dm-devel@redhat.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=snitzer@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®