From: Andy Grover <agrover@redhat.com>
To: gregkh@linuxfoundation.org, snitzer@redhat.com
Cc: dm-devel@redhat.com, linux-kernel@vger.kernel.org
Subject: [PATCH 3/9] dm: Inline dm_build_path_uevent into dm_path_uevent
Date: Mon, 3 Oct 2016 12:22:54 -0700 [thread overview]
Message-ID: <1475522580-16723-4-git-send-email-agrover@redhat.com> (raw)
In-Reply-To: <1475522580-16723-1-git-send-email-agrover@redhat.com>
Since it's no longer an API boundary we can consolidate these two
functions.
Signed-off-by: Andy Grover <agrover@redhat.com>
---
drivers/md/dm-mpath.c | 59 +++++++++++++++++++--------------------------------
1 file changed, 22 insertions(+), 37 deletions(-)
diff --git a/drivers/md/dm-mpath.c b/drivers/md/dm-mpath.c
index c563b6d..75fe28a 100644
--- a/drivers/md/dm-mpath.c
+++ b/drivers/md/dm-mpath.c
@@ -1241,38 +1241,6 @@ static void multipath_dtr(struct dm_target *ti)
free_multipath(m);
}
-static struct dm_uevent *dm_build_path_uevent(struct mapped_device *md,
- struct dm_target *ti,
- enum kobject_action action,
- const char *dm_action,
- const char *path,
- unsigned nr_valid_paths)
-{
- struct dm_uevent *event;
-
- event = dm_build_uevent(md, ti, action, dm_action);
- if (IS_ERR(event))
- return event;
-
- if (add_uevent_var(&event->ku_env, "DM_PATH=%s", path)) {
- DMERR("%s: add_uevent_var() for DM_PATH failed", __func__);
- goto err_add;
- }
-
- if (add_uevent_var(&event->ku_env, "DM_NR_VALID_PATHS=%d",
- nr_valid_paths)) {
- DMERR("%s: add_uevent_var() for DM_NR_VALID_PATHS failed",
- __func__);
- goto err_add;
- }
-
- return event;
-
-err_add:
- dm_uevent_free(event);
- return ERR_PTR(-ENOMEM);
-}
-
/**
* dm_path_uevent - called to create a new path event and queue it
*
@@ -1293,14 +1261,31 @@ static void dm_path_uevent(enum dm_uevent_type event_type, struct dm_target *ti,
return;
}
- event = dm_build_path_uevent(md, ti,
- _dm_mpath_uevent_type_names[event_type].action,
- _dm_mpath_uevent_type_names[event_type].name,
- path, nr_valid_paths);
- if (IS_ERR(event))
+ event = dm_build_uevent(md,
+ ti,
+ _dm_mpath_uevent_type_names[event_type].action,
+ _dm_mpath_uevent_type_names[event_type].name);
+ if (IS_ERR(event)) {
+ DMERR("%s: dm_build_uevent() failed", __func__);
return;
+ }
+
+ if (add_uevent_var(&event->ku_env, "DM_PATH=%s", path)) {
+ DMERR("%s: add_uevent_var() for DM_PATH failed", __func__);
+ goto err;
+ }
+
+ if (add_uevent_var(&event->ku_env, "DM_NR_VALID_PATHS=%d",
+ nr_valid_paths)) {
+ DMERR("%s: add_uevent_var() for DM_NR_VALID_PATHS failed",
+ __func__);
+ goto err;
+ }
dm_uevent_add(md, &event->elist);
+ return;
+err:
+ dm_uevent_free(event);
}
/*
--
2.7.4
next prev parent reply other threads:[~2016-10-03 19:23 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-03 19:22 [PATCH 0/9] Generate uevents for all DM events Andy Grover
2016-10-03 19:22 ` [PATCH 1/9] dm: Do not export dm_send_uevents Andy Grover
2016-10-03 19:22 ` [PATCH 2/9] dm: Move multipath-specific stuff out of dm-uevent.c Andy Grover
2016-10-03 19:22 ` Andy Grover [this message]
2016-10-03 19:22 ` [PATCH 4/9] dm: Update dm-uevent.txt Andy Grover
2016-10-03 19:22 ` [PATCH 5/9] dm: Rename dm_build_uevent to dm_uevent_build Andy Grover
2016-10-03 19:22 ` [PATCH 6/9] dm: Rename dm_event_add to dm_event_queue Andy Grover
2016-10-03 19:22 ` [PATCH 7/9] dm: Implement dm_uevent_add() Andy Grover
2016-10-03 19:22 ` [PATCH 8/9] dm: Generate uevents for thin targets Andy Grover
2016-10-03 19:23 ` [PATCH 9/9] dm: Generate uevents for other targets Andy Grover
2016-10-03 19:29 ` [PATCH 0/9] Generate uevents for all DM events Mike Snitzer
2016-10-04 7:20 ` Greg KH
2016-10-04 23:39 ` Andy Grover
2016-10-05 0:40 ` [dm-devel] " Alasdair G Kergon
2016-10-05 6:26 ` Hannes Reinecke
2016-10-05 6:51 ` Greg KH
2016-10-05 17:06 ` Andy Grover
2016-10-05 17:43 ` Alasdair G Kergon
2016-10-05 22:30 ` Andy Grover
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1475522580-16723-4-git-send-email-agrover@redhat.com \
--to=agrover@redhat.com \
--cc=dm-devel@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®