From: Laura Abbott <labbott@redhat.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh@kernel.org>, Arnd Bergmann <arnd@arndb.de>
Cc: Laura Abbott <labbott@redhat.com>, linux-kernel@vger.kernel.org
Subject: [PATCH] driver core: Make Kconfig text for DEBUG_TEST_DRIVER_REMOVE stronger
Date: Fri, 7 Oct 2016 09:09:30 -0700 [thread overview]
Message-ID: <1475856570-10743-1-git-send-email-labbott@redhat.com> (raw)
In-Reply-To: <120f00f2-94b6-aead-7bb4-9917bc338660@redhat.com>
The current state of driver removal is not great.
CONFIG_DEBUG_TEST_DRIVER_REMOVE finds lots of errors. The help text
currently undersells exactly how many errors this option will find. Add
a bit more description to indicate this option shouldn't be turned on
unless you actually want to debug driver removal. The text can be
changed later when more drivers are fixed up.
Signed-off-by: Laura Abbott <labbott@redhat.com>
---
drivers/base/Kconfig | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/base/Kconfig b/drivers/base/Kconfig
index fdf44ca..d02e7c0 100644
--- a/drivers/base/Kconfig
+++ b/drivers/base/Kconfig
@@ -213,14 +213,16 @@ config DEBUG_DEVRES
If you are unsure about this, Say N here.
config DEBUG_TEST_DRIVER_REMOVE
- bool "Test driver remove calls during probe"
+ bool "Test driver remove calls during probe (UNSTABLE)"
depends on DEBUG_KERNEL
help
Say Y here if you want the Driver core to test driver remove functions
by calling probe, remove, probe. This tests the remove path without
having to unbind the driver or unload the driver module.
- If you are unsure about this, say N here.
+ This option is expected to find errors and may render your system
+ unusable. You should say N here unless you are explicitly looking to
+ test this functionality.
config SYS_HYPERVISOR
bool
--
2.7.4
next prev parent reply other threads:[~2016-10-07 16:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-06 23:53 CONFIG_DEBUG_TEST_DRIVER_REMOVE needs a warning Laura Abbott
2016-10-07 3:56 ` Greg Kroah-Hartman
2016-10-07 15:40 ` Laura Abbott
2016-10-07 4:06 ` Rob Herring
2016-10-07 15:45 ` Laura Abbott
2016-10-07 16:09 ` Laura Abbott [this message]
2016-10-31 10:12 ` [PATCH] driver core: Make Kconfig text for DEBUG_TEST_DRIVER_REMOVE stronger Geert Uytterhoeven
2016-10-31 12:21 ` Greg Kroah-Hartman
2016-10-31 12:28 ` Geert Uytterhoeven
2016-10-31 14:10 ` Rob Herring
2016-10-31 15:07 ` Greg Kroah-Hartman
2016-10-31 15:07 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1475856570-10743-1-git-send-email-labbott@redhat.com \
--to=labbott@redhat.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®