From: Laura Abbott <labbott@redhat.com>
To: Rob Herring <robh@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: CONFIG_DEBUG_TEST_DRIVER_REMOVE needs a warning
Date: Fri, 7 Oct 2016 08:45:45 -0700 [thread overview]
Message-ID: <1fea0fcb-c25c-407b-d3b4-5a9296ed3828@redhat.com> (raw)
In-Reply-To: <CAL_Jsq+30GuEJqEF5mnDtSBej3kKSVsGBKwm6bNGGzDxDHThVA@mail.gmail.com>
On 10/06/2016 09:06 PM, Rob Herring wrote:
> On Thu, Oct 6, 2016 at 6:53 PM, Laura Abbott <labbott@redhat.com> wrote:
>> On a whim, I decided to turn on CONFIG_DEBUG_TEST_DRIVER_REMOVE on
>> Fedora rawhide since it sounded harmless enough. It spewed warnings
>> and panicked some systems. Clearly it's doing its job
>> well of finding drivers that can't handle remove properly and I
>> underestimated it. I was expecting to maybe find a driver or two.
>> Can we get stronger Kconfig text indicating that this shouldn't be
>> turned on lightly? I'll be turning the option off in Fedora but sending
>> out reports from what was found.
>
> It hides behind CONFIG_DEBUG already. Is there a better option that
> distros won't turn on?
For Fedora rawhide, we tend to turn on debug options that don't have
a significant performance impact to hopefully make the kernel better
for Fedora stable releases. Apart from a more explicit Kconfig text,
you could hide it behind CONFIG_EXPERT which Fedora doesn't turn on
and is more of a hint that this should only be used in specific
circumstances.
>
> Rob
>
Thanks,
Laura
next prev parent reply other threads:[~2016-10-07 15:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-06 23:53 Laura Abbott
2016-10-07 3:56 ` Greg Kroah-Hartman
2016-10-07 15:40 ` Laura Abbott
2016-10-07 4:06 ` Rob Herring
2016-10-07 15:45 ` Laura Abbott [this message]
2016-10-07 16:09 ` [PATCH] driver core: Make Kconfig text for DEBUG_TEST_DRIVER_REMOVE stronger Laura Abbott
2016-10-31 10:12 ` Geert Uytterhoeven
2016-10-31 12:21 ` Greg Kroah-Hartman
2016-10-31 12:28 ` Geert Uytterhoeven
2016-10-31 14:10 ` Rob Herring
2016-10-31 15:07 ` Greg Kroah-Hartman
2016-10-31 15:07 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1fea0fcb-c25c-407b-d3b4-5a9296ed3828@redhat.com \
--to=labbott@redhat.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®