From: Joe Perches <joe@perches.com>
To: Sabitha George <sabitha.george@gmail.com>,
gregkh@linuxfoundation.org, wsa+renesas@sang-engineering.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V3] staging: ks7010: use netdev_* instead of printk()
Date: Sun, 09 Oct 2016 22:56:02 -0700 [thread overview]
Message-ID: <1476078962.2856.20.camel@perches.com> (raw)
In-Reply-To: <1476078260-8827-1-git-send-email-sabitha.george@gmail.com>
On Mon, 2016-10-10 at 11:14 +0530, Sabitha George wrote:
> 1. Fixes checkpatch warning on printk usage in ks_hostif.c
> 2. Dropped "ks_wlan" prefix from the messages
> 3. Removed the "Memory squeeze,dropping packet" messages
[]
> diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c
[]
> @@ -549,7 +545,8 @@ void hostif_mib_get_confirm(struct ks_wlan_private *priv)
> dev->dev_addr[5] = priv->eth_addr[5];
> dev->dev_addr[6] = 0x00;
> dev->dev_addr[7] = 0x00;
> - printk(KERN_INFO "ks_wlan: MAC ADDRESS = %pM\n", priv->eth_addr);
> + netdev_info(dev, "MAC ADDRESS = %pM\n",
> + priv->eth_addr);
Do please use all 80 columns where possible.
netdev_info(dev, "MAC ADDRESS = %pM\n", priv->eth_addr);
prev parent reply other threads:[~2016-10-10 5:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-10 5:44 Sabitha George
2016-10-10 5:56 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1476078962.2856.20.camel@perches.com \
--to=joe@perches.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sabitha.george@gmail.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome