* [PATCH] crygpu/drm/exynos/exynos_hdmi - Unmap region obtained by of_iomap
@ 2016-10-17 11:09 ` Arvind Yadav
2016-10-17 11:33 ` Andrzej Hajda
0 siblings, 1 reply; 2+ messages in thread
From: Arvind Yadav @ 2016-10-17 11:09 UTC (permalink / raw)
To: airlied, krzk, kgene
Cc: inki.dae, jy0922.shim, sw0312.kim, kyungmin.park, dri-devel,
linux-arm-kernel, linux-samsung-soc, linux-kernel
Free memory mapping, if hdmi_probe is not successful.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/gpu/drm/exynos/exynos_hdmi.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c
index 2275efe..9b7857b 100644
--- a/drivers/gpu/drm/exynos/exynos_hdmi.c
+++ b/drivers/gpu/drm/exynos/exynos_hdmi.c
@@ -1901,6 +1901,8 @@ err_disable_pm_runtime:
err_hdmiphy:
if (hdata->hdmiphy_port)
put_device(&hdata->hdmiphy_port->dev);
+ if (hdata->regs_hdmiphy)
+ iounmap(hdata->regs_hdmiphy);
err_ddc:
put_device(&hdata->ddc_adpt->dev);
--
1.7.9.5
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] crygpu/drm/exynos/exynos_hdmi - Unmap region obtained by of_iomap
2016-10-17 11:09 ` [PATCH] crygpu/drm/exynos/exynos_hdmi - Unmap region obtained by of_iomap Arvind Yadav
@ 2016-10-17 11:33 ` Andrzej Hajda
0 siblings, 0 replies; 2+ messages in thread
From: Andrzej Hajda @ 2016-10-17 11:33 UTC (permalink / raw)
To: Arvind Yadav, airlied, krzk, kgene
Cc: inki.dae, jy0922.shim, sw0312.kim, kyungmin.park, dri-devel,
linux-arm-kernel, linux-samsung-soc, linux-kernel
Hi,
On 17.10.2016 13:09, Arvind Yadav wrote:
> Free memory mapping, if hdmi_probe is not successful.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Subject prefix is incorrect.
> ---
> drivers/gpu/drm/exynos/exynos_hdmi.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c
> index 2275efe..9b7857b 100644
> --- a/drivers/gpu/drm/exynos/exynos_hdmi.c
> +++ b/drivers/gpu/drm/exynos/exynos_hdmi.c
> @@ -1901,6 +1901,8 @@ err_disable_pm_runtime:
> err_hdmiphy:
> if (hdata->hdmiphy_port)
> put_device(&hdata->hdmiphy_port->dev);
> + if (hdata->regs_hdmiphy)
> + iounmap(hdata->regs_hdmiphy);
Thats OK, you can add also unmap to hdmi_remove.
Regards
Andrzej
> err_ddc:
> put_device(&hdata->ddc_adpt->dev);
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-10-17 11:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20161017111000eucas1p13f38f6daa20992f6aa3c9dfc8d2ab495@eucas1p1.samsung.com>
2016-10-17 11:09 ` [PATCH] crygpu/drm/exynos/exynos_hdmi - Unmap region obtained by of_iomap Arvind Yadav
2016-10-17 11:33 ` Andrzej Hajda
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®