mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chenhui Zhao <chenhui.zhao@nxp.com>
To: <linux-pm@vger.kernel.org>, <rjw@rjwysocki.net>,
	<daniel.lezcano@linaro.org>, <linux-kernel@vger.kernel.org>
Cc: <z.chenhui@gmail.com>, Chenhui Zhao <chenhui.zhao@nxp.com>
Subject: [PATCH] cpuidle: remove cpu_pm calls when entering a idle state
Date: Fri, 21 Oct 2016 17:32:57 +0800	[thread overview]
Message-ID: <1477042377-13485-1-git-send-email-chenhui.zhao@nxp.com> (raw)

The functions, cpu_pm_enter and cpu_pm_exit, assume that CPU would
be reset when entering and exiting a idle state. If that is not the
case, they would cause issue.

Signed-off-by: Chenhui Zhao <chenhui.zhao@nxp.com>
---
 include/linux/cpuidle.h | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/include/linux/cpuidle.h b/include/linux/cpuidle.h
index bb31373..063af89 100644
--- a/include/linux/cpuidle.h
+++ b/include/linux/cpuidle.h
@@ -261,12 +261,7 @@ static inline int cpuidle_register_governor(struct cpuidle_governor *gov)
 		return idx;					\
 	}							\
 								\
-	__ret = cpu_pm_enter();					\
-	if (!__ret) {						\
-		__ret = low_level_idle_enter(idx);		\
-		cpu_pm_exit();					\
-	}							\
-								\
+	__ret = low_level_idle_enter(idx);			\
 	__ret ? -1 : idx;					\
 })
 
-- 
1.9.1

             reply	other threads:[~2016-10-21  9:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-21  9:32 Chenhui Zhao [this message]
2016-10-21  9:59 ` Sudeep Holla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1477042377-13485-1-git-send-email-chenhui.zhao@nxp.com \
    --to=chenhui.zhao@nxp.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    --cc=z.chenhui@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®