* [PATCH] cpuidle: remove cpu_pm calls when entering a idle state
@ 2016-10-21 9:32 Chenhui Zhao
2016-10-21 9:59 ` Sudeep Holla
0 siblings, 1 reply; 2+ messages in thread
From: Chenhui Zhao @ 2016-10-21 9:32 UTC (permalink / raw)
To: linux-pm, rjw, daniel.lezcano, linux-kernel; +Cc: z.chenhui, Chenhui Zhao
The functions, cpu_pm_enter and cpu_pm_exit, assume that CPU would
be reset when entering and exiting a idle state. If that is not the
case, they would cause issue.
Signed-off-by: Chenhui Zhao <chenhui.zhao@nxp.com>
---
include/linux/cpuidle.h | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/include/linux/cpuidle.h b/include/linux/cpuidle.h
index bb31373..063af89 100644
--- a/include/linux/cpuidle.h
+++ b/include/linux/cpuidle.h
@@ -261,12 +261,7 @@ static inline int cpuidle_register_governor(struct cpuidle_governor *gov)
return idx; \
} \
\
- __ret = cpu_pm_enter(); \
- if (!__ret) { \
- __ret = low_level_idle_enter(idx); \
- cpu_pm_exit(); \
- } \
- \
+ __ret = low_level_idle_enter(idx); \
__ret ? -1 : idx; \
})
--
1.9.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] cpuidle: remove cpu_pm calls when entering a idle state
2016-10-21 9:32 [PATCH] cpuidle: remove cpu_pm calls when entering a idle state Chenhui Zhao
@ 2016-10-21 9:59 ` Sudeep Holla
0 siblings, 0 replies; 2+ messages in thread
From: Sudeep Holla @ 2016-10-21 9:59 UTC (permalink / raw)
To: Chenhui Zhao
Cc: Linux PM list, Rafael J. Wysocki, Daniel Lezcano, open list,
z.chenhui, Sudeep Holla
Hi Chenhui,
On Fri, Oct 21, 2016 at 10:32 AM, Chenhui Zhao <chenhui.zhao@nxp.com> wrote:
> The functions, cpu_pm_enter and cpu_pm_exit, assume that CPU would
> be reset when entering and exiting a idle state. If that is not the
> case, they would cause issue.
>
So are you OK to break all the states that would be reset ?
This is not a proper solution. Can you provide more details on the issue
you are facing ? What platform ? which idle states ? and so on..
Regards,
Sudeep
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-10-21 9:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-21 9:32 [PATCH] cpuidle: remove cpu_pm calls when entering a idle state Chenhui Zhao
2016-10-21 9:59 ` Sudeep Holla
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®