mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andreas Gruenbacher <agruenba@redhat.com>
To: Casey Schaufler <casey@schaufler-ca.com>,
	Al Viro <viro@zeniv.linux.org.uk>
Cc: Andreas Gruenbacher <agruenba@redhat.com>,
	linux-kernel@vger.kernel.org,
	linux-security-module@vger.kernel.org,
	Stephen Smalley <sds@tycho.nsa.gov>
Subject: Re: [PATCH] xattr: Fix setting security xattrs on sockfs
Date: Thu,  3 Nov 2016 17:00:59 +0100	[thread overview]
Message-ID: <1478188859-12354-1-git-send-email-agruenba@redhat.com> (raw)
In-Reply-To: <afcdbb40-2092-5279-665e-43999033539a@schaufler-ca.com>

On Thu, Nov 3, 2016 at 4:51 PM, Casey Schaufler <casey@schaufler-ca.com> wrote:
> On 11/3/2016 6:45 AM, Andreas Gruenbacher wrote:
>> Casey, the first patch broke filesystems that support setxattr for some xattrs
>> but not security xattrs.  Here's an updated patch; could you please test?
>
> This patch does not fix the problem. I am back to EOPTNOTSUP.

Ah, I forgot to register the new sockfs xattr handler.  Does this help?

Thanks,
Andreas

---
 net/socket.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/socket.c b/net/socket.c
index 816392a..9820725 100644
--- a/net/socket.c
+++ b/net/socket.c
@@ -357,6 +357,7 @@ static const struct xattr_handler sockfs_security_xattr_handler = {
 
 static const struct xattr_handler *sockfs_xattr_handlers[] = {
 	&sockfs_xattr_handler,
+	&sockfs_security_xattr_handler,
 	NULL
 };
 
-- 
2.7.4

  reply	other threads:[~2016-11-03 16:01 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-31 21:55 Problem with setxattr on sockfs with Smack after 971df15bd54ad46e907046ff33750a137b2f0096 Casey Schaufler
2016-11-01 16:10 ` Casey Schaufler
2016-11-02 19:34   ` [PATCH] " Andreas Gruenbacher
2016-11-02 20:09     ` Casey Schaufler
2016-11-03 13:45       ` [PATCH] xattr: Fix setting security xattrs on sockfs Andreas Gruenbacher
2016-11-03 15:51         ` Casey Schaufler
2016-11-03 16:00           ` Andreas Gruenbacher [this message]
2016-11-03 16:25             ` Casey Schaufler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1478188859-12354-1-git-send-email-agruenba@redhat.com \
    --to=agruenba@redhat.com \
    --cc=casey@schaufler-ca.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=sds@tycho.nsa.gov \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®