mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] lockdep: Remove unused parameter in add_lock_to_list() function
@ 2016-11-08  8:02 Tahsin Erdogan
  2016-11-11  7:36 ` [tip:locking/core] locking/lockdep: Remove unused parameter from the " tip-bot for Tahsin Erdogan
  0 siblings, 1 reply; 2+ messages in thread
From: Tahsin Erdogan @ 2016-11-08  8:02 UTC (permalink / raw)
  To: Peter Zijlstra, Ingo Molnar; +Cc: linux-kernel, Tahsin Erdogan

class parameter is not used, remove it.

Signed-off-by: Tahsin Erdogan <tahsin@google.com>
---
 kernel/locking/lockdep.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c
index 589d763a49b3..e74b438c850b 100644
--- a/kernel/locking/lockdep.c
+++ b/kernel/locking/lockdep.c
@@ -840,9 +840,9 @@ static struct lock_list *alloc_list_entry(void)
 /*
  * Add a new dependency to the head of the list:
  */
-static int add_lock_to_list(struct lock_class *class, struct lock_class *this,
-			    struct list_head *head, unsigned long ip,
-			    int distance, struct stack_trace *trace)
+static int add_lock_to_list(struct lock_class *this, struct list_head *head,
+			    unsigned long ip, int distance,
+			    struct stack_trace *trace)
 {
 	struct lock_list *entry;
 	/*
@@ -1869,14 +1869,14 @@ check_prev_add(struct task_struct *curr, struct held_lock *prev,
 	 * Ok, all validations passed, add the new lock
 	 * to the previous lock's dependency list:
 	 */
-	ret = add_lock_to_list(hlock_class(prev), hlock_class(next),
+	ret = add_lock_to_list(hlock_class(next),
 			       &hlock_class(prev)->locks_after,
 			       next->acquire_ip, distance, &trace);
 
 	if (!ret)
 		return 0;
 
-	ret = add_lock_to_list(hlock_class(next), hlock_class(prev),
+	ret = add_lock_to_list(hlock_class(prev),
 			       &hlock_class(next)->locks_before,
 			       next->acquire_ip, distance, &trace);
 	if (!ret)
-- 
2.8.0.rc3.226.g39d4020

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [tip:locking/core] locking/lockdep: Remove unused parameter from the add_lock_to_list() function
  2016-11-08  8:02 [PATCH] lockdep: Remove unused parameter in add_lock_to_list() function Tahsin Erdogan
@ 2016-11-11  7:36 ` tip-bot for Tahsin Erdogan
  0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Tahsin Erdogan @ 2016-11-11  7:36 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: linux-kernel, peterz, tahsin, mingo, tglx, torvalds, hpa

Commit-ID:  83f06168ef15da5dc735c7ea14fae67609ed9538
Gitweb:     http://git.kernel.org/tip/83f06168ef15da5dc735c7ea14fae67609ed9538
Author:     Tahsin Erdogan <tahsin@google.com>
AuthorDate: Tue, 8 Nov 2016 00:02:07 -0800
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Fri, 11 Nov 2016 08:25:20 +0100

locking/lockdep: Remove unused parameter from the add_lock_to_list() function

The 'class' parameter is not used, remove it.
n
Signed-off-by: Tahsin Erdogan <tahsin@google.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/1478592127-4376-1-git-send-email-tahsin@google.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 kernel/locking/lockdep.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c
index 589d763..e74b438 100644
--- a/kernel/locking/lockdep.c
+++ b/kernel/locking/lockdep.c
@@ -840,9 +840,9 @@ static struct lock_list *alloc_list_entry(void)
 /*
  * Add a new dependency to the head of the list:
  */
-static int add_lock_to_list(struct lock_class *class, struct lock_class *this,
-			    struct list_head *head, unsigned long ip,
-			    int distance, struct stack_trace *trace)
+static int add_lock_to_list(struct lock_class *this, struct list_head *head,
+			    unsigned long ip, int distance,
+			    struct stack_trace *trace)
 {
 	struct lock_list *entry;
 	/*
@@ -1869,14 +1869,14 @@ check_prev_add(struct task_struct *curr, struct held_lock *prev,
 	 * Ok, all validations passed, add the new lock
 	 * to the previous lock's dependency list:
 	 */
-	ret = add_lock_to_list(hlock_class(prev), hlock_class(next),
+	ret = add_lock_to_list(hlock_class(next),
 			       &hlock_class(prev)->locks_after,
 			       next->acquire_ip, distance, &trace);
 
 	if (!ret)
 		return 0;
 
-	ret = add_lock_to_list(hlock_class(next), hlock_class(prev),
+	ret = add_lock_to_list(hlock_class(prev),
 			       &hlock_class(next)->locks_before,
 			       next->acquire_ip, distance, &trace);
 	if (!ret)

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-11-12 21:17 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-08  8:02 [PATCH] lockdep: Remove unused parameter in add_lock_to_list() function Tahsin Erdogan
2016-11-11  7:36 ` [tip:locking/core] locking/lockdep: Remove unused parameter from the " tip-bot for Tahsin Erdogan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome