From: Vitaly Kuznetsov <vkuznets@redhat.com>
To: devel@linuxdriverproject.org
Cc: linux-kernel@vger.kernel.org,
"K. Y. Srinivasan" <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Dexuan Cui <decui@microsoft.com>,
Stephen Hemminger <stephen@networkplumber.org>
Subject: [PATCH 1/7] hv: acquire vmbus_connection.channel_mutex in vmbus_free_channels()
Date: Fri, 25 Nov 2016 13:48:37 +0100 [thread overview]
Message-ID: <1480078123-17582-2-git-send-email-vkuznets@redhat.com> (raw)
In-Reply-To: <1480078123-17582-1-git-send-email-vkuznets@redhat.com>
"kernel BUG at drivers/hv/channel_mgmt.c:350!" is observed when hv_vmbus
module is unloaded. BUG_ON() was introduced in commit 85d9aa705184
("Drivers: hv: vmbus: add an API vmbus_hvsock_device_unregister()") as
vmbus_free_channels() codepath was apparently forgotten.
Fixes: 85d9aa705184 ("Drivers: hv: vmbus: add an API vmbus_hvsock_device_unregister()")
Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
---
drivers/hv/channel_mgmt.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/hv/channel_mgmt.c b/drivers/hv/channel_mgmt.c
index 96a85cd..1bc1d479 100644
--- a/drivers/hv/channel_mgmt.c
+++ b/drivers/hv/channel_mgmt.c
@@ -389,6 +389,7 @@ void vmbus_free_channels(void)
{
struct vmbus_channel *channel, *tmp;
+ mutex_lock(&vmbus_connection.channel_mutex);
list_for_each_entry_safe(channel, tmp, &vmbus_connection.chn_list,
listentry) {
/* hv_process_channel_removal() needs this */
@@ -396,6 +397,7 @@ void vmbus_free_channels(void)
vmbus_device_unregister(channel->device_obj);
}
+ mutex_unlock(&vmbus_connection.channel_mutex);
}
/*
--
2.7.4
next prev parent reply other threads:[~2016-11-25 13:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-25 12:48 [PATCH 0/7] hv: CPU onlining/offlining fixes and improvements Vitaly Kuznetsov
2016-11-25 12:48 ` Vitaly Kuznetsov [this message]
2016-11-28 6:20 ` [PATCH 1/7] hv: acquire vmbus_connection.channel_mutex in vmbus_free_channels() Dexuan Cui
2016-11-25 12:48 ` [PATCH 2/7] hv: allocate synic pages for all present CPUs Vitaly Kuznetsov
2016-11-25 12:48 ` [PATCH 3/7] hv: init percpu_list in hv_synic_alloc() Vitaly Kuznetsov
2016-11-25 12:48 ` [PATCH 4/7] hv: change clockevents unbind tactics Vitaly Kuznetsov
2016-11-25 12:48 ` [PATCH 5/7] hv: check all present cpus in vmbus_wait_for_unload() Vitaly Kuznetsov
2016-11-25 12:48 ` [PATCH 6/7] hv: switch to cpuhp state machine for synic init/cleanup Vitaly Kuznetsov
2016-11-25 12:48 ` [PATCH 7/7] hv: make CPU offlining prevention fine-grained Vitaly Kuznetsov
2016-11-26 17:05 ` [PATCH 0/7] hv: CPU onlining/offlining fixes and improvements Stephen Hemminger
2016-11-28 6:56 ` Dexuan Cui
2016-11-28 9:12 ` Vitaly Kuznetsov
2017-01-02 19:49 ` Vitaly Kuznetsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1480078123-17582-2-git-send-email-vkuznets@redhat.com \
--to=vkuznets@redhat.com \
--cc=decui@microsoft.com \
--cc=devel@linuxdriverproject.org \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome