mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Vitaly Kuznetsov <vkuznets@redhat.com>
To: devel@linuxdriverproject.org
Cc: linux-kernel@vger.kernel.org,
	"K. Y. Srinivasan" <kys@microsoft.com>,
	Haiyang Zhang <haiyangz@microsoft.com>,
	Dexuan Cui <decui@microsoft.com>,
	Stephen Hemminger <stephen@networkplumber.org>
Subject: [PATCH 3/7] hv: init percpu_list in hv_synic_alloc()
Date: Fri, 25 Nov 2016 13:48:39 +0100	[thread overview]
Message-ID: <1480078123-17582-4-git-send-email-vkuznets@redhat.com> (raw)
In-Reply-To: <1480078123-17582-1-git-send-email-vkuznets@redhat.com>

Initializing hv_context.percpu_list in hv_synic_alloc() helps to prevent a
crash in percpu_channel_enq() when not all CPUs were online during
initialization and it naturally belongs there.

Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
---
 drivers/hv/hv.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/hv/hv.c b/drivers/hv/hv.c
index e4bb498..a2567a4 100644
--- a/drivers/hv/hv.c
+++ b/drivers/hv/hv.c
@@ -457,6 +457,8 @@ int hv_synic_alloc(void)
 			pr_err("Unable to allocate post msg page\n");
 			goto err;
 		}
+
+		INIT_LIST_HEAD(&hv_context.percpu_list[cpu]);
 	}
 
 	return 0;
@@ -552,8 +554,6 @@ void hv_synic_init(void *arg)
 	rdmsrl(HV_X64_MSR_VP_INDEX, vp_index);
 	hv_context.vp_index[cpu] = (u32)vp_index;
 
-	INIT_LIST_HEAD(&hv_context.percpu_list[cpu]);
-
 	/*
 	 * Register the per-cpu clockevent source.
 	 */
-- 
2.7.4

  parent reply	other threads:[~2016-11-25 12:59 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-25 12:48 [PATCH 0/7] hv: CPU onlining/offlining fixes and improvements Vitaly Kuznetsov
2016-11-25 12:48 ` [PATCH 1/7] hv: acquire vmbus_connection.channel_mutex in vmbus_free_channels() Vitaly Kuznetsov
2016-11-28  6:20   ` Dexuan Cui
2016-11-25 12:48 ` [PATCH 2/7] hv: allocate synic pages for all present CPUs Vitaly Kuznetsov
2016-11-25 12:48 ` Vitaly Kuznetsov [this message]
2016-11-25 12:48 ` [PATCH 4/7] hv: change clockevents unbind tactics Vitaly Kuznetsov
2016-11-25 12:48 ` [PATCH 5/7] hv: check all present cpus in vmbus_wait_for_unload() Vitaly Kuznetsov
2016-11-25 12:48 ` [PATCH 6/7] hv: switch to cpuhp state machine for synic init/cleanup Vitaly Kuznetsov
2016-11-25 12:48 ` [PATCH 7/7] hv: make CPU offlining prevention fine-grained Vitaly Kuznetsov
2016-11-26 17:05 ` [PATCH 0/7] hv: CPU onlining/offlining fixes and improvements Stephen Hemminger
2016-11-28  6:56   ` Dexuan Cui
2016-11-28  9:12     ` Vitaly Kuznetsov
2017-01-02 19:49 ` Vitaly Kuznetsov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1480078123-17582-4-git-send-email-vkuznets@redhat.com \
    --to=vkuznets@redhat.com \
    --cc=decui@microsoft.com \
    --cc=devel@linuxdriverproject.org \
    --cc=haiyangz@microsoft.com \
    --cc=kys@microsoft.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome