* [PATCH] Input: touchscreen: ads7846 - change msleep to usleep_range for small msecs
@ 2016-11-28 18:40 Aniroop Mathur
0 siblings, 0 replies; only message in thread
From: Aniroop Mathur @ 2016-11-28 18:40 UTC (permalink / raw)
To: imre.deak, dmitry.torokhov, linux-input, linux-kernel
Cc: s.samuel, r.mahale, aniroop.mathur, Aniroop Mathur
msleep(1~20) may not do what the caller intends, and will often sleep longer.
(~20 ms actual sleep for any value given in the 1~20ms range)
This is not the desired behaviour for many cases like device resume time,
device suspend time, device enable time, retry logic, etc.
Thus, change msleep to usleep_range for precise wakeups.
Signed-off-by: Aniroop Mathur <a.mathur@samsung.com>
---
drivers/input/touchscreen/ads7846.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/input/touchscreen/ads7846.c b/drivers/input/touchscreen/ads7846.c
index 1ce3ecb..b1a5a6c 100644
--- a/drivers/input/touchscreen/ads7846.c
+++ b/drivers/input/touchscreen/ads7846.c
@@ -58,7 +58,7 @@
* files.
*/
-#define TS_POLL_DELAY 1 /* ms delay before the first sample */
+#define TS_POLL_DELAY 1000 /* us delay before the first sample */
#define TS_POLL_PERIOD 5 /* ms delay between samples */
/* this driver doesn't aim at the peak continuous sample rate */
@@ -857,7 +857,7 @@ static irqreturn_t ads7846_irq(int irq, void *handle)
struct ads7846 *ts = handle;
/* Start with a small delay before checking pendown state */
- msleep(TS_POLL_DELAY);
+ usleep_range(TS_POLL_DELAY, TS_POLL_DELAY + 100);
while (!ts->stopped && get_pendown_state(ts)) {
--
2.6.2
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2016-11-28 18:31 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-28 18:40 [PATCH] Input: touchscreen: ads7846 - change msleep to usleep_range for small msecs Aniroop Mathur
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®