* [PATCH] drivers/of: fix missing pr_cont()s in of_print_phandle_args
@ 2016-12-01 8:00 Marcin Nowakowski
2016-12-09 16:32 ` Rob Herring
0 siblings, 1 reply; 2+ messages in thread
From: Marcin Nowakowski @ 2016-12-01 8:00 UTC (permalink / raw)
To: Rob Herring, Frank Rowand, devicetree, linux-kernel
Since the KERN_CONT changes, the current debug printks have a lot of
empty lines making the log messages very hard to read.
Signed-off-by: Marcin Nowakowski <marcin.nowakowski@imgtec.com>
---
drivers/of/base.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/of/base.c b/drivers/of/base.c
index 0810c5e..bae07f5 100644
--- a/drivers/of/base.c
+++ b/drivers/of/base.c
@@ -1566,9 +1566,12 @@ void of_print_phandle_args(const char *msg, const struct of_phandle_args *args)
{
int i;
printk("%s %s", msg, of_node_full_name(args->np));
- for (i = 0; i < args->args_count; i++)
- printk(i ? ",%08x" : ":%08x", args->args[i]);
- printk("\n");
+ for (i = 0; i < args->args_count; i++) {
+ const char delim = i ? ',' : ':';
+
+ pr_cont("%c%08x", delim, args->args[i]);
+ }
+ pr_cont("\n");
}
int of_phandle_iterator_init(struct of_phandle_iterator *it,
--
2.7.4
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] drivers/of: fix missing pr_cont()s in of_print_phandle_args
2016-12-01 8:00 [PATCH] drivers/of: fix missing pr_cont()s in of_print_phandle_args Marcin Nowakowski
@ 2016-12-09 16:32 ` Rob Herring
0 siblings, 0 replies; 2+ messages in thread
From: Rob Herring @ 2016-12-09 16:32 UTC (permalink / raw)
To: Marcin Nowakowski; +Cc: Frank Rowand, devicetree, linux-kernel
On Thu, Dec 01, 2016 at 09:00:55AM +0100, Marcin Nowakowski wrote:
> Since the KERN_CONT changes, the current debug printks have a lot of
> empty lines making the log messages very hard to read.
>
> Signed-off-by: Marcin Nowakowski <marcin.nowakowski@imgtec.com>
> ---
> drivers/of/base.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
Applied, thanks.
Rob
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-12-09 16:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-01 8:00 [PATCH] drivers/of: fix missing pr_cont()s in of_print_phandle_args Marcin Nowakowski
2016-12-09 16:32 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®