mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Nicolai Hähnle" <nhaehnle@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: "Nicolai Hähnle" <Nicolai.Haehnle@amd.com>,
	"Peter Zijlstra" <peterz@infradead.org>,
	"Ingo Molnar" <mingo@redhat.com>,
	"Maarten Lankhorst" <dev@mblankhorst.nl>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	"Chris Wilson" <chris@chris-wilson.co.uk>,
	dri-devel@lists.freedesktop.org
Subject: [PATCH v2 10/11] Documentation/locking/ww_mutex: Update the design document
Date: Thu,  1 Dec 2016 15:06:53 +0100	[thread overview]
Message-ID: <1480601214-26583-11-git-send-email-nhaehnle@gmail.com> (raw)
In-Reply-To: <1480601214-26583-1-git-send-email-nhaehnle@gmail.com>

From: Nicolai Hähnle <Nicolai.Haehnle@amd.com>

Document the invariants we maintain for the wait list of ww_mutexes.

Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Maarten Lankhorst <dev@mblankhorst.nl>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Nicolai Hähnle <Nicolai.Haehnle@amd.com>
---
 Documentation/locking/ww-mutex-design.txt | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/Documentation/locking/ww-mutex-design.txt b/Documentation/locking/ww-mutex-design.txt
index 8a112dc..34c3a1b 100644
--- a/Documentation/locking/ww-mutex-design.txt
+++ b/Documentation/locking/ww-mutex-design.txt
@@ -309,11 +309,15 @@ Design:
   normal mutex locks, which are far more common. As such there is only a small
   increase in code size if wait/wound mutexes are not used.
 
+  We maintain the following invariants for the wait list:
+  (1) Waiters with an acquire context are sorted by stamp order; waiters
+      without an acquire context are interspersed in FIFO order.
+  (2) Among waiters with contexts, only the first one can have other locks
+      acquired already (ctx->acquired > 0). Note that this waiter may come
+      after other waiters without contexts in the list.
+
   In general, not much contention is expected. The locks are typically used to
-  serialize access to resources for devices. The only way to make wakeups
-  smarter would be at the cost of adding a field to struct mutex_waiter. This
-  would add overhead to all cases where normal mutexes are used, and
-  ww_mutexes are generally less performance sensitive.
+  serialize access to resources for devices.
 
 Lockdep:
   Special care has been taken to warn for as many cases of api abuse
-- 
2.7.4

  parent reply	other threads:[~2016-12-01 14:07 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-01 14:06 [PATCH v2 00/11] locking/ww_mutex: Keep sorted wait list to avoid stampedes Nicolai Hähnle
2016-12-01 14:06 ` [PATCH v2 01/11] drm/vgem: Use ww_mutex_(un)lock even with a NULL context Nicolai Hähnle
2016-12-01 14:18   ` Chris Wilson
2016-12-01 15:14     ` Daniel Vetter
2016-12-01 16:24   ` Peter Zijlstra
2016-12-01 14:06 ` [PATCH v2 02/11] locking/ww_mutex: Re-check ww->ctx in the inner optimistic spin loop Nicolai Hähnle
2016-12-01 14:36   ` Chris Wilson
2016-12-06 15:06   ` Peter Zijlstra
2016-12-06 16:03     ` Waiman Long
2016-12-06 18:29       ` Peter Zijlstra
2016-12-06 18:46         ` Waiman Long
2016-12-01 14:06 ` [PATCH v2 03/11] locking/ww_mutex: Extract stamp comparison to __ww_mutex_stamp_after Nicolai Hähnle
2016-12-01 14:42   ` Chris Wilson
2016-12-01 14:06 ` [PATCH v2 04/11] locking/ww_mutex: Set use_ww_ctx even when locking without a context Nicolai Hähnle
2016-12-06 15:14   ` Peter Zijlstra
2016-12-06 15:25   ` Peter Zijlstra
2016-12-16 13:17     ` Nicolai Hähnle
2016-12-17  7:53       ` Maarten Lankhorst
2016-12-17 13:49       ` Peter Zijlstra
2016-12-01 14:06 ` [PATCH v2 05/11] locking/ww_mutex: Add waiters in stamp order Nicolai Hähnle
2016-12-01 15:59   ` Chris Wilson
2016-12-16 14:21     ` Nicolai Hähnle
2016-12-06 15:36   ` Peter Zijlstra
2016-12-16 13:34     ` Nicolai Hähnle
2016-12-06 16:55   ` Peter Zijlstra
2016-12-16 14:19     ` Nicolai Hähnle
2016-12-16 14:46       ` Peter Zijlstra
2016-12-16 17:15       ` Peter Zijlstra
2016-12-16 18:11         ` Nicolai Hähnle
2016-12-16 20:00           ` Peter Zijlstra
2016-12-16 22:35             ` Nicolai Hähnle
2016-12-16 17:20       ` Peter Zijlstra
2016-12-16 18:12         ` Nicolai Hähnle
2016-12-01 14:06 ` [PATCH v2 06/11] locking/ww_mutex: Notify waiters that have to back off while adding tasks to wait list Nicolai Hähnle
2016-12-01 14:06 ` [PATCH v2 07/11] locking/ww_mutex: Wake at most one waiter for back off when acquiring the lock Nicolai Hähnle
2016-12-01 14:06 ` [PATCH v2 08/11] locking/ww_mutex: Yield to other waiters from optimistic spin Nicolai Hähnle
2016-12-01 14:06 ` [PATCH v2 09/11] locking/mutex: Initialize mutex_waiter::ww_ctx with poison when debugging Nicolai Hähnle
2016-12-01 14:06 ` Nicolai Hähnle [this message]
2016-12-01 14:06 ` [PATCH v2 11/11] [rfc] locking/ww_mutex: Always spin optimistically for the first waiter Nicolai Hähnle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1480601214-26583-11-git-send-email-nhaehnle@gmail.com \
    --to=nhaehnle@gmail.com \
    --cc=Nicolai.Haehnle@amd.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=daniel@ffwll.ch \
    --cc=dev@mblankhorst.nl \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®