From: kys@exchange.microsoft.com
To: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
devel@linuxdriverproject.org, olaf@aepfle.de, apw@canonical.com,
vkuznets@redhat.com, jasowang@redhat.com,
leann.ogasawara@canonical.com
Cc: Alex Fluter <afluter@yandex.com>, "K. Y. Srinivasan" <kys@microsoft.com>
Subject: [PATCH V2 14/15] Tools: hv: kvp: configurable external scripts path
Date: Sat, 3 Dec 2016 12:34:41 -0800 [thread overview]
Message-ID: <1480797282-10126-14-git-send-email-kys@exchange.microsoft.com> (raw)
In-Reply-To: <1480797282-10126-1-git-send-email-kys@exchange.microsoft.com>
From: Alex Fluter <afluter@yandex.com>
error when running hypervkvpd:
$ sudo ./hv_kvp_daemon -n
sh: hv_get_dns_info: command not found
sh: hv_get_dhcp_info: command not found
sh: hv_get_dns_info: command not found
sh: hv_get_dhcp_info: command not found
The external scripts are not installed in system path,
adding a configurable macro.
Signed-off-by: Alex Fluter <afluter@yandex.com>
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
---
tools/hv/hv_kvp_daemon.c | 11 ++++++++---
1 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/tools/hv/hv_kvp_daemon.c b/tools/hv/hv_kvp_daemon.c
index d791dbf..f1758fc 100644
--- a/tools/hv/hv_kvp_daemon.c
+++ b/tools/hv/hv_kvp_daemon.c
@@ -93,6 +93,10 @@ enum {
#define KVP_CONFIG_LOC "/var/lib/hyperv"
+#ifndef KVP_SCRIPTS_PATH
+#define KVP_SCRIPTS_PATH "/usr/libexec/hypervkvpd/"
+#endif
+
#define MAX_FILE_NAME 100
#define ENTRIES_PER_BLOCK 50
@@ -818,7 +822,7 @@ static void kvp_get_ipconfig_info(char *if_name,
* .
*/
- sprintf(cmd, "%s", "hv_get_dns_info");
+ sprintf(cmd, KVP_SCRIPTS_PATH "%s", "hv_get_dns_info");
/*
* Execute the command to gather DNS info.
@@ -835,7 +839,7 @@ static void kvp_get_ipconfig_info(char *if_name,
* Enabled: DHCP enabled.
*/
- sprintf(cmd, "%s %s", "hv_get_dhcp_info", if_name);
+ sprintf(cmd, KVP_SCRIPTS_PATH "%s %s", "hv_get_dhcp_info", if_name);
file = popen(cmd, "r");
if (file == NULL)
@@ -1341,7 +1345,8 @@ static int kvp_set_ip_info(char *if_name, struct hv_kvp_ipaddr_value *new_val)
* invoke the external script to do its magic.
*/
- snprintf(cmd, sizeof(cmd), "%s %s", "hv_set_ifconfig", if_file);
+ snprintf(cmd, sizeof(cmd), KVP_SCRIPTS_PATH "%s %s",
+ "hv_set_ifconfig", if_file);
if (system(cmd)) {
syslog(LOG_ERR, "Failed to execute cmd '%s'; error: %d %s",
cmd, errno, strerror(errno));
--
1.7.4.1
next prev parent reply other threads:[~2016-12-03 18:41 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-03 20:33 [PATCH V2 00/15] Drivers: hv: CPU management fixes and a new uio driver kys
2016-12-03 20:34 ` [PATCH V2 01/15] Drivers: hv: vmbus: Raise retry/wait limits in vmbus_post_msg() kys
2016-12-03 20:34 ` [PATCH V2 02/15] hyperv: Fix spelling of HV_UNKOWN kys
2016-12-03 20:34 ` [PATCH V2 03/15] Drivers: hv: vmbus: Prevent sending data on a rescinded channel kys
2016-12-03 20:34 ` [PATCH V2 04/15] Drivers: hv: vmbus: Enhance the rescind callback functionality kys
2016-12-06 10:08 ` Greg KH
2016-12-03 20:34 ` [PATCH V2 05/15] hv: acquire vmbus_connection.channel_mutex in vmbus_free_channels() kys
2016-12-03 20:34 ` [PATCH V2 06/15] hv: allocate synic pages for all present CPUs kys
2016-12-06 10:09 ` Greg KH
2016-12-03 20:34 ` [PATCH V2 07/15] hv: init percpu_list in hv_synic_alloc() kys
2016-12-06 10:09 ` Greg KH
2016-12-03 20:34 ` [PATCH V2 08/15] hv: change clockevents unbind tactics kys
2016-12-03 20:34 ` [PATCH V2 09/15] hv: switch to cpuhp state machine for synic init/cleanup kys
2016-12-03 20:34 ` [PATCH V2 10/15] hv: make CPU offlining prevention fine-grained kys
2016-12-03 20:34 ` [PATCH V2 11/15] hv: don't reset hv_context.tsc_page on crash kys
2016-12-03 20:34 ` [PATCH V2 12/15] vmbus: add support for dynamic device id's kys
2016-12-03 20:34 ` [PATCH V2 13/15] uio-hv-generic: new userspace i/o driver for VMBus kys
2016-12-03 20:34 ` kys [this message]
2016-12-03 20:34 ` [PATCH V2 15/15] hyperv: Add a function to detect if the device is a vmbus dev kys
2016-12-06 10:54 ` Greg KH
2016-12-06 14:58 ` KY Srinivasan
2016-12-06 10:07 ` [PATCH V2 01/15] Drivers: hv: vmbus: Raise retry/wait limits in vmbus_post_msg() Greg KH
2016-12-06 10:54 ` [PATCH V2 00/15] Drivers: hv: CPU management fixes and a new uio driver Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1480797282-10126-14-git-send-email-kys@exchange.microsoft.com \
--to=kys@exchange.microsoft.com \
--cc=afluter@yandex.com \
--cc=apw@canonical.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=jasowang@redhat.com \
--cc=kys@microsoft.com \
--cc=leann.ogasawara@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=olaf@aepfle.de \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®