mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: kys@exchange.microsoft.com
To: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
	devel@linuxdriverproject.org, olaf@aepfle.de, apw@canonical.com,
	vkuznets@redhat.com, jasowang@redhat.com,
	leann.ogasawara@canonical.com
Cc: "K. Y. Srinivasan" <kys@microsoft.com>, <Stable@vger.kernel.org>
Subject: [PATCH V2 05/15] hv: acquire vmbus_connection.channel_mutex in vmbus_free_channels()
Date: Sat,  3 Dec 2016 12:34:32 -0800	[thread overview]
Message-ID: <1480797282-10126-5-git-send-email-kys@exchange.microsoft.com> (raw)
In-Reply-To: <1480797282-10126-1-git-send-email-kys@exchange.microsoft.com>

From: Vitaly Kuznetsov <vkuznets@redhat.com>

"kernel BUG at drivers/hv/channel_mgmt.c:350!" is observed when hv_vmbus
module is unloaded. BUG_ON() was introduced in commit 85d9aa705184
("Drivers: hv: vmbus: add an API vmbus_hvsock_device_unregister()") as
vmbus_free_channels() codepath was apparently forgotten.

Fixes: 85d9aa705184 ("Drivers: hv: vmbus: add an API vmbus_hvsock_device_unregister()")

Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Cc: <Stable@vger.kernel.org>
---
 drivers/hv/channel_mgmt.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/hv/channel_mgmt.c b/drivers/hv/channel_mgmt.c
index d83c1ac..e68f06c 100644
--- a/drivers/hv/channel_mgmt.c
+++ b/drivers/hv/channel_mgmt.c
@@ -390,6 +390,7 @@ void vmbus_free_channels(void)
 {
 	struct vmbus_channel *channel, *tmp;
 
+	mutex_lock(&vmbus_connection.channel_mutex);
 	list_for_each_entry_safe(channel, tmp, &vmbus_connection.chn_list,
 		listentry) {
 		/* hv_process_channel_removal() needs this */
@@ -397,6 +398,7 @@ void vmbus_free_channels(void)
 
 		vmbus_device_unregister(channel->device_obj);
 	}
+	mutex_unlock(&vmbus_connection.channel_mutex);
 }
 
 /*
-- 
1.7.4.1

  parent reply	other threads:[~2016-12-03 18:39 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-03 20:33 [PATCH V2 00/15] Drivers: hv: CPU management fixes and a new uio driver kys
2016-12-03 20:34 ` [PATCH V2 01/15] Drivers: hv: vmbus: Raise retry/wait limits in vmbus_post_msg() kys
2016-12-03 20:34   ` [PATCH V2 02/15] hyperv: Fix spelling of HV_UNKOWN kys
2016-12-03 20:34   ` [PATCH V2 03/15] Drivers: hv: vmbus: Prevent sending data on a rescinded channel kys
2016-12-03 20:34   ` [PATCH V2 04/15] Drivers: hv: vmbus: Enhance the rescind callback functionality kys
2016-12-06 10:08     ` Greg KH
2016-12-03 20:34   ` kys [this message]
2016-12-03 20:34   ` [PATCH V2 06/15] hv: allocate synic pages for all present CPUs kys
2016-12-06 10:09     ` Greg KH
2016-12-03 20:34   ` [PATCH V2 07/15] hv: init percpu_list in hv_synic_alloc() kys
2016-12-06 10:09     ` Greg KH
2016-12-03 20:34   ` [PATCH V2 08/15] hv: change clockevents unbind tactics kys
2016-12-03 20:34   ` [PATCH V2 09/15] hv: switch to cpuhp state machine for synic init/cleanup kys
2016-12-03 20:34   ` [PATCH V2 10/15] hv: make CPU offlining prevention fine-grained kys
2016-12-03 20:34   ` [PATCH V2 11/15] hv: don't reset hv_context.tsc_page on crash kys
2016-12-03 20:34   ` [PATCH V2 12/15] vmbus: add support for dynamic device id's kys
2016-12-03 20:34   ` [PATCH V2 13/15] uio-hv-generic: new userspace i/o driver for VMBus kys
2016-12-03 20:34   ` [PATCH V2 14/15] Tools: hv: kvp: configurable external scripts path kys
2016-12-03 20:34   ` [PATCH V2 15/15] hyperv: Add a function to detect if the device is a vmbus dev kys
2016-12-06 10:54     ` Greg KH
2016-12-06 14:58       ` KY Srinivasan
2016-12-06 10:07   ` [PATCH V2 01/15] Drivers: hv: vmbus: Raise retry/wait limits in vmbus_post_msg() Greg KH
2016-12-06 10:54 ` [PATCH V2 00/15] Drivers: hv: CPU management fixes and a new uio driver Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1480797282-10126-5-git-send-email-kys@exchange.microsoft.com \
    --to=kys@exchange.microsoft.com \
    --cc=Stable@vger.kernel.org \
    --cc=apw@canonical.com \
    --cc=devel@linuxdriverproject.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jasowang@redhat.com \
    --cc=kys@microsoft.com \
    --cc=leann.ogasawara@canonical.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=olaf@aepfle.de \
    --cc=vkuznets@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome