From: kan.liang@intel.com
To: peterz@infradead.org, mingo@redhat.com, acme@kernel.org,
linux-kernel@vger.kernel.org
Cc: alexander.shishkin@linux.intel.com, tglx@linutronix.de,
namhyung@kernel.org, jolsa@kernel.org, adrian.hunter@intel.com,
wangnan0@huawei.com, mark.rutland@arm.com, andi@firstfloor.org,
Kan Liang <kan.liang@intel.com>
Subject: [PATCH V3 2/6] perf/core: Add PERF_EVENT_IOC_STAT to control overhead statistics
Date: Thu, 8 Dec 2016 16:27:10 -0500 [thread overview]
Message-ID: <1481232434-3574-3-git-send-email-kan.liang@intel.com> (raw)
In-Reply-To: <1481232434-3574-1-git-send-email-kan.liang@intel.com>
From: Kan Liang <kan.liang@intel.com>
It only needs to generate the overhead statistics once when perf is
done. But there is no good place in the kernel for that.
A new ioctl PERF_EVENT_IOC_STAT is introduced to notify the kernel when
the tool 'start' and 'done'.
In 'start', the kernel resets the overhead numbers.
In 'done', the kernel generates pmu's overhead.
It also needs a pmu specific int (*stat) to do the real work.
Signed-off-by: Kan Liang <kan.liang@intel.com>
---
include/linux/perf_event.h | 6 ++++++
include/uapi/linux/perf_event.h | 3 +++
kernel/events/core.c | 5 +++++
3 files changed, 14 insertions(+)
diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h
index 946e8d8..a34f9a2 100644
--- a/include/linux/perf_event.h
+++ b/include/linux/perf_event.h
@@ -403,6 +403,12 @@ struct pmu {
*/
void (*sched_task) (struct perf_event_context *ctx,
bool sched_in);
+
+ /*
+ * overhead statistics
+ */
+ int (*stat) (struct perf_event *event, u32 flag);
+
/*
* PMU specific data size
*/
diff --git a/include/uapi/linux/perf_event.h b/include/uapi/linux/perf_event.h
index 101f8b3..23b7963 100644
--- a/include/uapi/linux/perf_event.h
+++ b/include/uapi/linux/perf_event.h
@@ -408,9 +408,12 @@ struct perf_event_attr {
#define PERF_EVENT_IOC_ID _IOR('$', 7, __u64 *)
#define PERF_EVENT_IOC_SET_BPF _IOW('$', 8, __u32)
#define PERF_EVENT_IOC_PAUSE_OUTPUT _IOW('$', 9, __u32)
+#define PERF_EVENT_IOC_STAT _IOW('$', 10, __u32)
enum perf_event_ioc_flags {
PERF_IOC_FLAG_GROUP = 1U << 0,
+ PERF_IOC_FLAG_STAT_START = 1U << 1,
+ PERF_IOC_FLAG_STAT_DONE = 1U << 2,
};
/*
diff --git a/kernel/events/core.c b/kernel/events/core.c
index 1420139..dbde193 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -4637,6 +4637,11 @@ static long _perf_ioctl(struct perf_event *event, unsigned int cmd, unsigned lon
rcu_read_unlock();
return 0;
}
+ case PERF_EVENT_IOC_STAT: {
+ if (event->pmu->stat)
+ return event->pmu->stat(event, flags);
+ return 0;
+ }
default:
return -ENOTTY;
}
--
2.4.3
next prev parent reply other threads:[~2016-12-08 21:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-08 21:27 [PATCH V3 0/6] export perf overheads information (kernel) kan.liang
2016-12-08 21:27 ` [PATCH V3 1/6] perf/core: Introduce PERF_RECORD_OVERHEAD kan.liang
2016-12-08 21:27 ` kan.liang [this message]
2016-12-08 21:27 ` [PATCH V3 3/6] perf/x86: implement overhead stat for x86 pmu kan.liang
2016-12-08 21:27 ` [PATCH V3 4/6] perf/core: calculate multiplexing overhead kan.liang
2016-12-08 21:27 ` [PATCH V3 5/6] perf/core: calculate side-band events overhead kan.liang
2016-12-08 21:27 ` [PATCH V3 6/6] perf/x86: calculate sampling overhead kan.liang
2016-12-16 15:08 ` [PATCH V3 0/6] export perf overheads information (kernel) Liang, Kan
2017-01-06 15:25 ` Liang, Kan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1481232434-3574-3-git-send-email-kan.liang@intel.com \
--to=kan.liang@intel.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®