From: kan.liang@intel.com
To: peterz@infradead.org, mingo@redhat.com, acme@kernel.org,
linux-kernel@vger.kernel.org
Cc: alexander.shishkin@linux.intel.com, tglx@linutronix.de,
namhyung@kernel.org, jolsa@kernel.org, adrian.hunter@intel.com,
wangnan0@huawei.com, mark.rutland@arm.com, andi@firstfloor.org,
Kan Liang <kan.liang@intel.com>
Subject: [PATCH V3 6/6] perf/x86: calculate sampling overhead
Date: Thu, 8 Dec 2016 16:27:14 -0500 [thread overview]
Message-ID: <1481232434-3574-7-git-send-email-kan.liang@intel.com> (raw)
In-Reply-To: <1481232434-3574-1-git-send-email-kan.liang@intel.com>
From: Kan Liang <kan.liang@intel.com>
On x86, NMI handler is the most important part which brings overhead
for sampling. Adding a pmu specific overhead type
PERF_PMU_SAMPLE_OVERHEAD for it.
For other architectures which may don't have NMI, the overhead type can
be reused.
Signed-off-by: Kan Liang <kan.liang@intel.com>
---
arch/x86/events/core.c | 8 +++++++-
include/uapi/linux/perf_event.h | 1 +
2 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/arch/x86/events/core.c b/arch/x86/events/core.c
index 09ab36a..1e57ccf 100644
--- a/arch/x86/events/core.c
+++ b/arch/x86/events/core.c
@@ -1478,8 +1478,10 @@ void perf_events_lapic_init(void)
static int
perf_event_nmi_handler(unsigned int cmd, struct pt_regs *regs)
{
+ struct perf_cpu_context *cpuctx = this_cpu_ptr(pmu.pmu_cpu_context);
u64 start_clock;
u64 finish_clock;
+ u64 clock;
int ret;
/*
@@ -1492,8 +1494,12 @@ perf_event_nmi_handler(unsigned int cmd, struct pt_regs *regs)
start_clock = sched_clock();
ret = x86_pmu.handle_irq(regs);
finish_clock = sched_clock();
+ clock = finish_clock - start_clock;
+ perf_sample_event_took(clock);
- perf_sample_event_took(finish_clock - start_clock);
+ /* calculate NMI overhead */
+ cpuctx->overhead[PERF_PMU_SAMPLE_OVERHEAD].nr++;
+ cpuctx->overhead[PERF_PMU_SAMPLE_OVERHEAD].time += clock;
return ret;
}
diff --git a/include/uapi/linux/perf_event.h b/include/uapi/linux/perf_event.h
index 7ba6d30..954b116 100644
--- a/include/uapi/linux/perf_event.h
+++ b/include/uapi/linux/perf_event.h
@@ -1004,6 +1004,7 @@ enum perf_record_overhead_type {
PERF_CORE_MUX_OVERHEAD = 0,
PERF_CORE_SB_OVERHEAD,
/* PMU specific */
+ PERF_PMU_SAMPLE_OVERHEAD,
PERF_OVERHEAD_MAX,
};
--
2.4.3
next prev parent reply other threads:[~2016-12-08 21:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-08 21:27 [PATCH V3 0/6] export perf overheads information (kernel) kan.liang
2016-12-08 21:27 ` [PATCH V3 1/6] perf/core: Introduce PERF_RECORD_OVERHEAD kan.liang
2016-12-08 21:27 ` [PATCH V3 2/6] perf/core: Add PERF_EVENT_IOC_STAT to control overhead statistics kan.liang
2016-12-08 21:27 ` [PATCH V3 3/6] perf/x86: implement overhead stat for x86 pmu kan.liang
2016-12-08 21:27 ` [PATCH V3 4/6] perf/core: calculate multiplexing overhead kan.liang
2016-12-08 21:27 ` [PATCH V3 5/6] perf/core: calculate side-band events overhead kan.liang
2016-12-08 21:27 ` kan.liang [this message]
2016-12-16 15:08 ` [PATCH V3 0/6] export perf overheads information (kernel) Liang, Kan
2017-01-06 15:25 ` Liang, Kan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1481232434-3574-7-git-send-email-kan.liang@intel.com \
--to=kan.liang@intel.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®