From: Alexander Popov <alex.popov@linux.com>
To: Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Mark Rutland <mark.rutland@arm.com>,
Rob Herring <robh@kernel.org>,
Kefeng Wang <wangkefeng.wang@huawei.com>,
AKASHI Takahiro <takahiro.akashi@linaro.org>,
Jon Masters <jcm@redhat.com>,
David Daney <david.daney@cavium.com>,
Ganapatrao Kulkarni <gkulkarni@caviumnetworks.com>,
Andrew Morton <akpm@linux-foundation.org>,
Dmitry Vyukov <dvyukov@google.com>,
Nicolai Stange <nicstange@gmail.com>,
James Morse <james.morse@arm.com>,
Andrey Ryabinin <aryabinin@virtuozzo.com>,
Andrey Konovalov <andreyknvl@google.com>,
Alexander Popov <alex.popov@linux.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
syzkaller <syzkaller@googlegroups.com>
Subject: [PATCH 2/2] kcov: make kcov work properly with KASLR enabled
Date: Sun, 11 Dec 2016 03:50:56 +0300 [thread overview]
Message-ID: <1481417456-28826-3-git-send-email-alex.popov@linux.com> (raw)
In-Reply-To: <1481417456-28826-1-git-send-email-alex.popov@linux.com>
Subtract KASLR offset from the kernel addresses reported by kcov.
Tested on x86_64 and AArch64 (Hikey LeMaker).
Signed-off-by: Alexander Popov <alex.popov@linux.com>
---
kernel/kcov.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/kernel/kcov.c b/kernel/kcov.c
index 3cbb0c8..f8f3f4c 100644
--- a/kernel/kcov.c
+++ b/kernel/kcov.c
@@ -14,6 +14,7 @@
#include <linux/debugfs.h>
#include <linux/uaccess.h>
#include <linux/kcov.h>
+#include <asm/setup.h>
/*
* kcov descriptor (one per opened debugfs file).
@@ -68,6 +69,11 @@ void notrace __sanitizer_cov_trace_pc(void)
if (mode == KCOV_MODE_TRACE) {
unsigned long *area;
unsigned long pos;
+ unsigned long ip = _RET_IP_;
+
+#ifdef CONFIG_RANDOMIZE_BASE
+ ip -= kaslr_offset();
+#endif
/*
* There is some code that runs in interrupts but for which
@@ -81,7 +87,7 @@ void notrace __sanitizer_cov_trace_pc(void)
/* The first word is number of subsequent PCs. */
pos = READ_ONCE(area[0]) + 1;
if (likely(pos < t->kcov_size)) {
- area[pos] = _RET_IP_;
+ area[pos] = ip;
WRITE_ONCE(area[0], pos);
}
}
--
2.7.4
next prev parent reply other threads:[~2016-12-11 0:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-11 0:50 [PATCH 0/2] Make " Alexander Popov
2016-12-11 0:50 ` [PATCH 1/2] arm64: setup: introduce kaslr_offset() Alexander Popov
2016-12-12 11:29 ` Will Deacon
2016-12-13 22:07 ` Alexander Popov
2016-12-22 6:18 ` Yury Norov
2016-12-22 12:51 ` Alexander Popov
2017-01-03 11:18 ` Jon Hunter
2017-01-03 11:32 ` Will Deacon
2016-12-11 0:50 ` Alexander Popov [this message]
2016-12-11 9:32 ` [PATCH 2/2] kcov: make kcov work properly with KASLR enabled Dmitry Vyukov
2016-12-11 21:37 ` Alexander Popov
2016-12-12 6:58 ` Dmitry Vyukov
2017-01-26 11:53 ` Quentin Casasnovas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1481417456-28826-3-git-send-email-alex.popov@linux.com \
--to=alex.popov@linux.com \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@google.com \
--cc=ard.biesheuvel@linaro.org \
--cc=aryabinin@virtuozzo.com \
--cc=catalin.marinas@arm.com \
--cc=david.daney@cavium.com \
--cc=dvyukov@google.com \
--cc=gkulkarni@caviumnetworks.com \
--cc=james.morse@arm.com \
--cc=jcm@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=nicstange@gmail.com \
--cc=robh@kernel.org \
--cc=syzkaller@googlegroups.com \
--cc=takahiro.akashi@linaro.org \
--cc=wangkefeng.wang@huawei.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®