From: Alexander Popov <alex.popov@linux.com>
To: Dmitry Vyukov <dvyukov@google.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Mark Rutland <mark.rutland@arm.com>,
Rob Herring <robh@kernel.org>,
Kefeng Wang <wangkefeng.wang@huawei.com>,
AKASHI Takahiro <takahiro.akashi@linaro.org>,
Jon Masters <jcm@redhat.com>,
David Daney <david.daney@cavium.com>,
Ganapatrao Kulkarni <gkulkarni@caviumnetworks.com>,
Andrew Morton <akpm@linux-foundation.org>,
Nicolai Stange <nicstange@gmail.com>,
James Morse <james.morse@arm.com>,
Andrey Ryabinin <aryabinin@virtuozzo.com>,
Andrey Konovalov <andreyknvl@google.com>,
linux-arm-kernel@lists.infradead.org,
LKML <linux-kernel@vger.kernel.org>,
syzkaller <syzkaller@googlegroups.com>,
Quentin Casasnovas <quentin.casasnovas@oracle.com>
Subject: Re: [PATCH 2/2] kcov: make kcov work properly with KASLR enabled
Date: Mon, 12 Dec 2016 00:37:16 +0300 [thread overview]
Message-ID: <f3f9c3a3-349d-65ff-6c84-51878cfd8072@linux.com> (raw)
In-Reply-To: <CACT4Y+bOd-Lzs45jyEr73GkRc7zZDxL8Z3fSc+TeZVRNVC6M-A@mail.gmail.com>
On 11.12.2016 12:32, Dmitry Vyukov wrote:
> On Sun, Dec 11, 2016 at 1:50 AM, Alexander Popov <alex.popov@linux.com> wrote:
>> Subtract KASLR offset from the kernel addresses reported by kcov.
>> Tested on x86_64 and AArch64 (Hikey LeMaker).
>>
>> Signed-off-by: Alexander Popov <alex.popov@linux.com>
>> ---
>> kernel/kcov.c | 8 +++++++-
>> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> I think generally this is the right thing to do.
>
> There are 2 pending patches for kcov by +Quentin (hopefully in mm):
> "kcov: add AFL-style tracing"
> "kcov: size of arena is now given in bytes"
> https://groups.google.com/forum/#!topic/syzkaller/gcqbIhKjGcY
> https://groups.google.com/d/msg/syzkaller/gcqbIhKjGcY/KQFryjBKCAAJ
>
> Your patch probably conflicts with them.
> Should you base them on top of these patches, so that Andrew can merge
> it without conflicts?
Excuse me, I can't find these patches in:
git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
git://git.kernel.org/pub/scm/linux/kernel/git/mhocko/mm.git
git://git.cmpxchg.org/linux-mmots.git
Could you point at the tree which I can rebase onto?
Should I cherry-pick Quentin's patches manually?
Best regards,
Alexander
next prev parent reply other threads:[~2016-12-11 21:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-11 0:50 [PATCH 0/2] Make " Alexander Popov
2016-12-11 0:50 ` [PATCH 1/2] arm64: setup: introduce kaslr_offset() Alexander Popov
2016-12-12 11:29 ` Will Deacon
2016-12-13 22:07 ` Alexander Popov
2016-12-22 6:18 ` Yury Norov
2016-12-22 12:51 ` Alexander Popov
2017-01-03 11:18 ` Jon Hunter
2017-01-03 11:32 ` Will Deacon
2016-12-11 0:50 ` [PATCH 2/2] kcov: make kcov work properly with KASLR enabled Alexander Popov
2016-12-11 9:32 ` Dmitry Vyukov
2016-12-11 21:37 ` Alexander Popov [this message]
2016-12-12 6:58 ` Dmitry Vyukov
2017-01-26 11:53 ` Quentin Casasnovas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3f9c3a3-349d-65ff-6c84-51878cfd8072@linux.com \
--to=alex.popov@linux.com \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@google.com \
--cc=ard.biesheuvel@linaro.org \
--cc=aryabinin@virtuozzo.com \
--cc=catalin.marinas@arm.com \
--cc=david.daney@cavium.com \
--cc=dvyukov@google.com \
--cc=gkulkarni@caviumnetworks.com \
--cc=james.morse@arm.com \
--cc=jcm@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=nicstange@gmail.com \
--cc=quentin.casasnovas@oracle.com \
--cc=robh@kernel.org \
--cc=syzkaller@googlegroups.com \
--cc=takahiro.akashi@linaro.org \
--cc=wangkefeng.wang@huawei.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®