* [V1] rtc:rtc-vr41xx :- Retunr error is not correct in rtc_probe
@ 2016-12-11 16:41 Arvind Yadav
0 siblings, 0 replies; only message in thread
From: Arvind Yadav @ 2016-12-11 16:41 UTC (permalink / raw)
To: a.zummo, alexandre.belloni; +Cc: rtc-linux, linux-kernel
Here, rtc_probe is returning EBUSY at any error case.
It should return ENOMEM insted of EBUSY.
-EBUSY A resource you need is not avaialable.
-ENOMEM This is used to signify lack of memory resources.
-ENODEV This is used when no device is available.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/rtc/rtc-vr41xx.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/rtc/rtc-vr41xx.c b/drivers/rtc/rtc-vr41xx.c
index e1b86bb..e666d8e 100644
--- a/drivers/rtc/rtc-vr41xx.c
+++ b/drivers/rtc/rtc-vr41xx.c
@@ -292,21 +292,21 @@ static int rtc_probe(struct platform_device *pdev)
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
if (!res)
- return -EBUSY;
+ return -ENOMEM;
rtc1_base = devm_ioremap(&pdev->dev, res->start, resource_size(res));
if (!rtc1_base)
- return -EBUSY;
+ return -ENOMEM;
res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
if (!res) {
- retval = -EBUSY;
+ retval = -ENOMEM;
goto err_rtc1_iounmap;
}
rtc2_base = devm_ioremap(&pdev->dev, res->start, resource_size(res));
if (!rtc2_base) {
- retval = -EBUSY;
+ retval = -ENOMEM;
goto err_rtc1_iounmap;
}
@@ -342,7 +342,7 @@ static int rtc_probe(struct platform_device *pdev)
pie_irq = platform_get_irq(pdev, 1);
if (pie_irq <= 0) {
- retval = -EBUSY;
+ retval = -ENODEV;
goto err_iounmap_all;
}
--
2.7.4
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2016-12-11 16:41 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-11 16:41 [V1] rtc:rtc-vr41xx :- Retunr error is not correct in rtc_probe Arvind Yadav
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®