* [PATCH] hwmon: (lm90) fix temp1_max_alarm attribute
@ 2017-01-02 16:53 Michael Walle
2017-01-02 18:15 ` Guenter Roeck
0 siblings, 1 reply; 2+ messages in thread
From: Michael Walle @ 2017-01-02 16:53 UTC (permalink / raw)
To: linux-hwmon; +Cc: Guenter Roeck, linux-kernel, Michael Walle
Since commit commit eb1c8f4325d5 ("hwmon: (lm90) Convert to use new hwmon
registration API") the temp1_max_alarm and temp1_crit_alarm attributes are
mapped to the same alarm bit. Fix the typo.
Fixes: eb1c8f4325d5 ("hwmon: (lm90) Convert to use new hwmon registration API")
Signed-off-by: Micehael Walle <michael@walle.cc>
---
drivers/hwmon/lm90.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hwmon/lm90.c b/drivers/hwmon/lm90.c
index 322ed92..841f242 100644
--- a/drivers/hwmon/lm90.c
+++ b/drivers/hwmon/lm90.c
@@ -1036,7 +1036,7 @@ static const u8 lm90_temp_emerg_index[3] = {
};
static const u8 lm90_min_alarm_bits[3] = { 5, 3, 11 };
-static const u8 lm90_max_alarm_bits[3] = { 0, 4, 12 };
+static const u8 lm90_max_alarm_bits[3] = { 6, 4, 12 };
static const u8 lm90_crit_alarm_bits[3] = { 0, 1, 9 };
static const u8 lm90_emergency_alarm_bits[3] = { 15, 13, 14 };
static const u8 lm90_fault_bits[3] = { 0, 2, 10 };
--
2.1.4
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] hwmon: (lm90) fix temp1_max_alarm attribute
2017-01-02 16:53 [PATCH] hwmon: (lm90) fix temp1_max_alarm attribute Michael Walle
@ 2017-01-02 18:15 ` Guenter Roeck
0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2017-01-02 18:15 UTC (permalink / raw)
To: Michael Walle, linux-hwmon; +Cc: linux-kernel
On 01/02/2017 08:53 AM, Michael Walle wrote:
> Since commit commit eb1c8f4325d5 ("hwmon: (lm90) Convert to use new hwmon
> registration API") the temp1_max_alarm and temp1_crit_alarm attributes are
> mapped to the same alarm bit. Fix the typo.
>
> Fixes: eb1c8f4325d5 ("hwmon: (lm90) Convert to use new hwmon registration API")
> Signed-off-by: Micehael Walle <michael@walle.cc>
Good catch. Applied.
Thanks,
Guenter
> ---
> drivers/hwmon/lm90.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/lm90.c b/drivers/hwmon/lm90.c
> index 322ed92..841f242 100644
> --- a/drivers/hwmon/lm90.c
> +++ b/drivers/hwmon/lm90.c
> @@ -1036,7 +1036,7 @@ static const u8 lm90_temp_emerg_index[3] = {
> };
>
> static const u8 lm90_min_alarm_bits[3] = { 5, 3, 11 };
> -static const u8 lm90_max_alarm_bits[3] = { 0, 4, 12 };
> +static const u8 lm90_max_alarm_bits[3] = { 6, 4, 12 };
> static const u8 lm90_crit_alarm_bits[3] = { 0, 1, 9 };
> static const u8 lm90_emergency_alarm_bits[3] = { 15, 13, 14 };
> static const u8 lm90_fault_bits[3] = { 0, 2, 10 };
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-01-02 18:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-02 16:53 [PATCH] hwmon: (lm90) fix temp1_max_alarm attribute Michael Walle
2017-01-02 18:15 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®