2.4.0-pre10: svclock: missing unlock_kernel()

2.4.0-pre10: svclock: missing unlock_kernel()

[Trond Myklebust]

Linus,

  I missed a conditional return in nlmsvc_notify_blocked() when we
should be releasing the BKL. Thanks to Jim Castleberry for pointing it 
out.

  Please note, however, that there remain serious bugs in 2.4.0-pre10
fs/locks.c w.r.t. notification of the filesystem/lockd that need to be
fixed before the 2.4.0 release.

Cheers,
  Trond


--- fs/lockd/svclock.c.orig	Tue Oct 31 00:31:49 2000
+++ fs/lockd/svclock.c	Wed Nov  1 12:57:25 2000
@@ -473,6 +473,7 @@
 		if (nlm_compare_locks(&block->b_call.a_args.lock.fl, fl)) {
 			nlmsvc_insert_block(block, 0);
 			svc_wake_up(block->b_daemon);
+			unlock_kernel();
 			return;
 		}
 	}
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/