[PATCH] regulator: gpio-regulator: constify regulator_ops structure

[PATCH] regulator: gpio-regulator: constify regulator_ops structure

[Bhumika Goyal]

Declare regulator_ops structure as const as it is only stored in the ops
field of a regulator_desc structure. This field is of type const, so
regulator_ops structures having this property can be made const too.

File size before: drivers/regulator/gpio-regulator.o
   text	   data	    bss	    dec	    hex	filename
   3273	    720	      0	   3993	    f99 regulator/gpio-regulator.o

File size after: drivers/regulator/gpio-regulator.o
   text	   data	    bss	    dec	    hex	filename
   3801	    192	      0	   3993	    f99 regulator/gpio-regulator.o

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
---
 drivers/regulator/gpio-regulator.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/regulator/gpio-regulator.c b/drivers/regulator/gpio-regulator.c
index 0fce06a..3f9a3ec 100644
--- a/drivers/regulator/gpio-regulator.c
+++ b/drivers/regulator/gpio-regulator.c
@@ -126,7 +126,7 @@ static int gpio_regulator_set_current_limit(struct regulator_dev *dev,
 	return 0;
 }
 
-static struct regulator_ops gpio_regulator_voltage_ops = {
+static const struct regulator_ops gpio_regulator_voltage_ops = {
 	.get_voltage = gpio_regulator_get_value,
 	.set_voltage = gpio_regulator_set_voltage,
 	.list_voltage = gpio_regulator_list_voltage,
@@ -243,7 +243,7 @@ static int gpio_regulator_set_current_limit(struct regulator_dev *dev,
 	return config;
 }
 
-static struct regulator_ops gpio_regulator_current_ops = {
+static const struct regulator_ops gpio_regulator_current_ops = {
 	.get_current_limit = gpio_regulator_get_value,
 	.set_current_limit = gpio_regulator_set_current_limit,
 };
-- 
1.9.1

Re: [PATCH] regulator: gpio-regulator: constify regulator_ops structure

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 353 bytes --]

On Sat, Jan 28, 2017 at 07:38:55PM +0530, Bhumika Goyal wrote:
> Declare regulator_ops structure as const as it is only stored in the ops
> field of a regulator_desc structure. This field is of type const, so
> regulator_ops structures having this property can be made const too.

This still doesn't apply against current code, please check and resend.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]