mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Peter Rosin <peda@axentia.se>
To: <linux-kernel@vger.kernel.org>
Cc: Peter Rosin <peda@axentia.se>,
	Jonathan Cameron <jic23@kernel.org>,
	Hartmut Knaack <knaack.h@gmx.de>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
	Alison Schofield <amsfield22@gmail.com>,
	Gregor Boirie <gregor.boirie@parrot.com>,
	Sanchayan Maity <maitysanchayan@gmail.com>,
	Ken Lin <ken.lin@advantech.com>, <linux-iio@vger.kernel.org>
Subject: [PATCH 2/2] iio: pressure: mpl115: do not rely on structure field ordering
Date: Wed, 1 Feb 2017 09:09:27 +0100	[thread overview]
Message-ID: <1485936567-3367-3-git-send-email-peda@axentia.se> (raw)
In-Reply-To: <1485936567-3367-1-git-send-email-peda@axentia.se>

Fixes a regression triggered by a change in the layout of
struct iio_chan_spec, but the real bug is in the driver which assumed
a specific structure layout in the first place.

Fixes: 3017d90e8931 ("iio: Add Freescale MPL115A2 pressure / temperature sensor driver")
Fixes: 51239600074b ("iio:core: add a callback to allow drivers to provide _available attributes")
Signed-off-by: Peter Rosin <peda@axentia.se>
---
 drivers/iio/pressure/mpl115.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/iio/pressure/mpl115.c b/drivers/iio/pressure/mpl115.c
index 73f2f0c46e62..8f2bce213248 100644
--- a/drivers/iio/pressure/mpl115.c
+++ b/drivers/iio/pressure/mpl115.c
@@ -137,6 +137,7 @@ static const struct iio_chan_spec mpl115_channels[] = {
 	{
 		.type = IIO_TEMP,
 		.info_mask_separate = BIT(IIO_CHAN_INFO_RAW),
+		.info_mask_shared_by_type =
 			BIT(IIO_CHAN_INFO_OFFSET) | BIT(IIO_CHAN_INFO_SCALE),
 	},
 };
-- 
2.1.4

  parent reply	other threads:[~2017-02-01  8:09 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-01  8:09 [PATCH 0/2] iio: pressure: " Peter Rosin
2017-02-01  8:09 ` [PATCH 1/2] iio: pressure: mpl3115: " Peter Rosin
2017-02-01  9:10   ` Peter Meerwald-Stadler
2017-02-01  9:13     ` Peter Rosin
2017-02-01  9:31       ` Peter Meerwald-Stadler
2017-02-01  9:43         ` Peter Rosin
2017-02-01  9:57           ` Peter Meerwald-Stadler
2017-02-01 10:18             ` Peter Rosin
     [not found]               ` <WM!e12d26e0b57c992627516bbebee1f0ac620aa97ce815547b240a5ff4318cef8602c115af08639804344b7a648bbe4b31!@dg.advantech.com>
     [not found]                 ` <03B5A3CA1724CE4EAC32B27E39292A677FC7512F94@AUSMAIL1.AUS.ADVANTECH.CORP>
2017-02-01 18:24                   ` Ken.Lin
2017-02-01 11:21   ` Jonathan Cameron
2017-02-01  8:09 ` Peter Rosin [this message]
2017-02-01  8:52 ` [PATCH 0/2] iio: pressure: " Lars-Peter Clausen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1485936567-3367-3-git-send-email-peda@axentia.se \
    --to=peda@axentia.se \
    --cc=amsfield22@gmail.com \
    --cc=gregor.boirie@parrot.com \
    --cc=jic23@kernel.org \
    --cc=ken.lin@advantech.com \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maitysanchayan@gmail.com \
    --cc=pmeerw@pmeerw.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®