From: Peter Rosin <peda@axentia.se>
To: Peter Meerwald-Stadler <pmeerw@pmeerw.net>
Cc: <linux-kernel@vger.kernel.org>,
Jonathan Cameron <jic23@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Alison Schofield <amsfield22@gmail.com>,
Gregor Boirie <gregor.boirie@parrot.com>,
Sanchayan Maity <maitysanchayan@gmail.com>,
Ken Lin <ken.lin@advantech.com>, <linux-iio@vger.kernel.org>
Subject: Re: [PATCH 1/2] iio: pressure: mpl3115: do not rely on structure field ordering
Date: Wed, 1 Feb 2017 11:18:20 +0100 [thread overview]
Message-ID: <2936f505-79d9-340e-4454-ec7ef0bc7236@axentia.se> (raw)
In-Reply-To: <alpine.DEB.2.02.1702011053190.3042@pmeerw.net>
On 2017-02-01 10:57, Peter Meerwald-Stadler wrote:
>>> - .info_mask_separate = BIT(IIO_CHAN_INFO_RAW),
>>> BIT(IIO_CHAN_INFO_SCALE),
>>> + .info_mask_separate = BIT(IIO_CHAN_INFO_RAW) |
>>> BIT(IIO_CHAN_INFO_SCALE),
>>> as originally intended
>>
>> I considered that option, but the code in mpl3115_read_raw (and
>> mpl115_read_raw for that matter) return constants fro these values which
>> to me indicated that they were not "separate" and as that would also be
>> the change which replicated the exact behavior from before the regression
>> I went with that. But I don't care either way, so I can re-spin if you
>> want me to? (But don't blame me if that regresses in some other
>> interesting way).
>
> no, all good; shared_by_type is the way to go
> I'd rather respin for the not ORed comment in the patch
Ok, but I think I'll wait a bit so that Ken Lin gets some time to verify
that it actually solves the original problem. It should, but...
Cheers,
peda
next prev parent reply other threads:[~2017-02-01 10:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-01 8:09 [PATCH 0/2] iio: pressure: " Peter Rosin
2017-02-01 8:09 ` [PATCH 1/2] iio: pressure: mpl3115: " Peter Rosin
2017-02-01 9:10 ` Peter Meerwald-Stadler
2017-02-01 9:13 ` Peter Rosin
2017-02-01 9:31 ` Peter Meerwald-Stadler
2017-02-01 9:43 ` Peter Rosin
2017-02-01 9:57 ` Peter Meerwald-Stadler
2017-02-01 10:18 ` Peter Rosin [this message]
[not found] ` <WM!e12d26e0b57c992627516bbebee1f0ac620aa97ce815547b240a5ff4318cef8602c115af08639804344b7a648bbe4b31!@dg.advantech.com>
[not found] ` <03B5A3CA1724CE4EAC32B27E39292A677FC7512F94@AUSMAIL1.AUS.ADVANTECH.CORP>
2017-02-01 18:24 ` Ken.Lin
2017-02-01 11:21 ` Jonathan Cameron
2017-02-01 8:09 ` [PATCH 2/2] iio: pressure: mpl115: " Peter Rosin
2017-02-01 8:52 ` [PATCH 0/2] iio: pressure: " Lars-Peter Clausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2936f505-79d9-340e-4454-ec7ef0bc7236@axentia.se \
--to=peda@axentia.se \
--cc=amsfield22@gmail.com \
--cc=gregor.boirie@parrot.com \
--cc=jic23@kernel.org \
--cc=ken.lin@advantech.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maitysanchayan@gmail.com \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®