From: Lucas Stach <l.stach@pengutronix.de>
To: Liviu Dudau <liviu@dudau.co.uk>
Cc: David Airlie <airlied@linux.ie>,
Russell King <linux+etnaviv@armlinux.org.uk>,
Christian Gmeiner <christian.gmeiner@gmail.com>,
etnaviv@lists.freedesktop.org,
DRI devel <dri-devel@lists.freedesktop.org>,
LKML <linux-kernel@vger.kernel.org>,
Dave Jiang <dave.jiang@intel.com>
Subject: Re: [PATCH 2/3] drm/etnaviv: Update etnaviv_gem_fault() declaration to match definition.
Date: Wed, 01 Feb 2017 10:26:08 +0100 [thread overview]
Message-ID: <1485941168.21479.38.camel@pengutronix.de> (raw)
In-Reply-To: <20170131185849.8297-2-liviu@dudau.co.uk>
Hi Liviu,
Am Dienstag, den 31.01.2017, 18:58 +0000 schrieb Liviu Dudau:
> Commit 25d3db7600b8 ("mm, fs: reduce fault, page_mkwrite, and pfn_mkwrite
> to take only vmf") updated the etnaviv_gem_fault() function signature
> without updating the header file with the declaration.
>
There is already a patch from Arnd on the list that fixes this issue.
https://lkml.org/lkml/2017/1/25/718
Regards,
Lucas
> Fixes: 25d3db7600b8 ("mm, fs: reduce fault, page_mkwrite, and pfn_mkwrite to take only vmf")
> Cc: Dave Jiang <dave.jiang@intel.com>
> Cc: Lucas Stach <l.stach@pengutronix.de>
> Cc: Russell King <linux+etnaviv@armlinux.org.uk>
> Cc: Christian Gmeiner <christian.gmeiner@gmail.com>
> Signed-off-by: Liviu Dudau <liviu@dudau.co.uk>
> ---
> drivers/gpu/drm/etnaviv/etnaviv_drv.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/etnaviv/etnaviv_drv.h b/drivers/gpu/drm/etnaviv/etnaviv_drv.h
> index c255eda40526..e41f38667c1c 100644
> --- a/drivers/gpu/drm/etnaviv/etnaviv_drv.h
> +++ b/drivers/gpu/drm/etnaviv/etnaviv_drv.h
> @@ -73,7 +73,7 @@ int etnaviv_ioctl_gem_submit(struct drm_device *dev, void *data,
> struct drm_file *file);
>
> int etnaviv_gem_mmap(struct file *filp, struct vm_area_struct *vma);
> -int etnaviv_gem_fault(struct vm_area_struct *vma, struct vm_fault *vmf);
> +int etnaviv_gem_fault(struct vm_fault *vmf);
> int etnaviv_gem_mmap_offset(struct drm_gem_object *obj, u64 *offset);
> struct sg_table *etnaviv_gem_prime_get_sg_table(struct drm_gem_object *obj);
> void *etnaviv_gem_prime_vmap(struct drm_gem_object *obj);
next prev parent reply other threads:[~2017-02-01 9:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-31 18:58 [PATCH 1/3] drm: armada: fix armada_gem_vm_fault() to match new signature Liviu Dudau
2017-01-31 18:58 ` [PATCH 2/3] drm/etnaviv: Update etnaviv_gem_fault() declaration to match definition Liviu Dudau
2017-02-01 9:26 ` Lucas Stach [this message]
2017-02-01 9:45 ` Liviu Dudau
2017-01-31 18:58 ` [PATCH 3/3] drm/omapdrm: Update omap_gem_fault() " Liviu Dudau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1485941168.21479.38.camel@pengutronix.de \
--to=l.stach@pengutronix.de \
--cc=airlied@linux.ie \
--cc=christian.gmeiner@gmail.com \
--cc=dave.jiang@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=etnaviv@lists.freedesktop.org \
--cc=linux+etnaviv@armlinux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=liviu@dudau.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®