* [PATCH] rbd: constify device_type structure
@ 2017-02-11 6:44 Bhumika Goyal
2017-02-13 9:12 ` Ilya Dryomov
0 siblings, 1 reply; 2+ messages in thread
From: Bhumika Goyal @ 2017-02-11 6:44 UTC (permalink / raw)
To: julia.lawall, idryomov, sage, elder, ceph-devel, linux-kernel
Cc: Bhumika Goyal
Declare device_type structure as const as it is only stored in the
type field of a device structure. This field is of type const, so add
const to the declaration of device_type structure.
File size before:
text data bss dec hex filename
61546 11610 208 73364 11e94 drivers/block/rbd.o
File size after:
text data bss dec hex filename
61610 11578 208 73396 11eb4 drivers/block/rbd.o
Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
---
drivers/block/rbd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c
index 36d2b9f..dfc708b 100644
--- a/drivers/block/rbd.c
+++ b/drivers/block/rbd.c
@@ -4779,7 +4779,7 @@ static ssize_t rbd_image_refresh(struct device *dev,
static void rbd_dev_release(struct device *dev);
-static struct device_type rbd_device_type = {
+static const struct device_type rbd_device_type = {
.name = "rbd",
.groups = rbd_attr_groups,
.release = rbd_dev_release,
--
1.9.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] rbd: constify device_type structure
2017-02-11 6:44 [PATCH] rbd: constify device_type structure Bhumika Goyal
@ 2017-02-13 9:12 ` Ilya Dryomov
0 siblings, 0 replies; 2+ messages in thread
From: Ilya Dryomov @ 2017-02-13 9:12 UTC (permalink / raw)
To: Bhumika Goyal
Cc: Julia Lawall, Sage Weil, Alex Elder, Ceph Development, linux-kernel
On Sat, Feb 11, 2017 at 7:44 AM, Bhumika Goyal <bhumirks@gmail.com> wrote:
> Declare device_type structure as const as it is only stored in the
> type field of a device structure. This field is of type const, so add
> const to the declaration of device_type structure.
>
> File size before:
> text data bss dec hex filename
> 61546 11610 208 73364 11e94 drivers/block/rbd.o
>
> File size after:
> text data bss dec hex filename
> 61610 11578 208 73396 11eb4 drivers/block/rbd.o
>
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
> ---
> drivers/block/rbd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c
> index 36d2b9f..dfc708b 100644
> --- a/drivers/block/rbd.c
> +++ b/drivers/block/rbd.c
> @@ -4779,7 +4779,7 @@ static ssize_t rbd_image_refresh(struct device *dev,
>
> static void rbd_dev_release(struct device *dev);
>
> -static struct device_type rbd_device_type = {
> +static const struct device_type rbd_device_type = {
> .name = "rbd",
> .groups = rbd_attr_groups,
> .release = rbd_dev_release,
Applied.
Thanks,
Ilya
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-02-13 9:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-11 6:44 [PATCH] rbd: constify device_type structure Bhumika Goyal
2017-02-13 9:12 ` Ilya Dryomov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®